Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tarfile.extractall fails to overwrite unresolved symlinks and hard links #56297

Closed
ScottLeerssen mannequin opened this issue May 16, 2011 · 4 comments
Closed

tarfile.extractall fails to overwrite unresolved symlinks and hard links #56297

ScottLeerssen mannequin opened this issue May 16, 2011 · 4 comments
Assignees
@orsenthil
Labels
stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@ScottLeerssen
Copy link
Mannequin

ScottLeerssen mannequin commented May 16, 2011

BPO 12088
Nosy @orsenthil

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = 'https://github.com/orsenthil'
closed_at = <Date 2011-05-17.02:16:01.221>
created_at = <Date 2011-05-16.14:01:04.451>
labels = ['type-bug', 'library']
title = 'tarfile.extractall fails to overwrite unresolved symlinks and hard links'
updated_at = <Date 2011-05-17.02:16:01.220>
user = 'https://bugs.python.org/ScottLeerssen'

bugs.python.org fields:

activity = <Date 2011-05-17.02:16:01.220>
actor = 'orsenthil'
assignee = 'orsenthil'
closed = True
closed_date = <Date 2011-05-17.02:16:01.221>
closer = 'orsenthil'
components = ['Library (Lib)']
creation = <Date 2011-05-16.14:01:04.451>
creator = 'Scott.Leerssen'
dependencies = []
files = []
hgrepos = []
issue_num = 12088
keywords = []
message_count = 4.0
messages = ['136091', '136093', '136134', '136135']
nosy_count = 3.0
nosy_names = ['orsenthil', 'python-dev', 'Scott.Leerssen']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue12088'
versions = ['Python 2.7']
@ScottLeerssen
Copy link
Mannequin Author

ScottLeerssen mannequin commented May 16, 2011

I'm opening this as a continuation of bpo-10761 since it was closed as fixed, and there's a bit more work to do there.

The fix for bpo-10761 was incomplete. It did not handle the case where the symlink being overwritten did not resolve to another file (i.e. a "broken" link). It also did not address the same issues with hard links.

The comments starting at http://bugs.python.org/issue10761#msg135924 detail the updates needed to complete this fix.

@ScottLeerssen ScottLeerssen mannequin added stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error labels May 16, 2011
@orsenthil
Copy link
Member

I looked at your message and the patch, seems okay for the case of testing if the symlink is broken and performing the next steps. I shall commit it soon.

@orsenthil orsenthil self-assigned this May 16, 2011
@python-dev
Copy link
Mannequin

python-dev mannequin commented May 17, 2011

New changeset b29f0b6fcb76 by Senthil Kumaran in branch '2.7':
Fix closes issue bpo-12088 - fixes the tarfile.extractall issue when the
http://hg.python.org/cpython/rev/b29f0b6fcb76

@orsenthil
Copy link
Member

Committed the fix. Thank you, Scott.

@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@orsenthil orsenthil

Labels
stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@orsenthil