Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include information about the bug tracker Rietveld code review tool #56078

Closed
ned-deily opened this issue Apr 18, 2011 · 4 comments
Closed

Include information about the bug tracker Rietveld code review tool #56078

ned-deily opened this issue Apr 18, 2011 · 4 comments
Assignees
@ezio-melotti
Labels
docs Documentation in the Doc dir type-feature A feature request or enhancement

Comments

@ned-deily
Copy link
Member

BPO 11869
Nosy @ned-deily, @ezio-melotti, @merwok, @bitdancer, @sandrotosi, @akheron
Superseder
  • bpo-13963: dev guide has no mention of mechanics of patch review
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/ezio-melotti'
closed_at = <Date 2013-03-14.07:51:42.649>
created_at = <Date 2011-04-18.20:00:07.657>
labels = ['type-feature', 'docs']
title = 'Include information about the bug tracker Rietveld code review tool'
updated_at = <Date 2013-03-14.07:51:42.647>
user = 'https://github.com/ned-deily'

    bugs.python.org fields:

    activity = <Date 2013-03-14.07:51:42.647>
actor = 'ezio.melotti'
assignee = 'ezio.melotti'
closed = True
closed_date = <Date 2013-03-14.07:51:42.649>
closer = 'ezio.melotti'
components = ['Devguide']
creation = <Date 2011-04-18.20:00:07.657>
creator = 'ned.deily'
dependencies = []
files = []
hgrepos = []
issue_num = 11869
keywords = []
message_count = 4.0
messages = ['133989', '138786', '171037', '184142']
nosy_count = 6.0
nosy_names = ['ned.deily', 'ezio.melotti', 'eric.araujo', 'r.david.murray', 'sandro.tosi', 'petri.lehtinen']
pr_nums = []
priority = 'normal'
resolution = 'duplicate'
stage = 'resolved'
status = 'closed'
superseder = '13963'
type = 'enhancement'
url = 'https://bugs.python.org/issue11869'
versions = []
    @ned-deily
    Copy link
    Member Author

    As far as I can see, the developer's guide does not mention at all the new Rietveld code review tool integration with the Python bug tracker. The guide should describe how the tool is expected to be used both by core developers reviewing submitted patches and by patch submitters.

    @ned-deily ned-deily added the docs Documentation in the Doc dir label Apr 18, 2011
    @bitdancer
    Copy link
    Member

    Heh. You are assuming we know how it "should" be used :) It's pretty new yet, so I don't think we've figured that out. But at at least how it works should be mentioned in the devguide.

    @ezio-melotti ezio-melotti self-assigned this Sep 23, 2012
    @ezio-melotti ezio-melotti added the type-feature A feature request or enhancement label Sep 23, 2012
    @ezio-melotti
    Copy link
    Member

    See also bpo-13963.

    @ezio-melotti
    Copy link
    Member

    Closing this as duplicate of bpo-13963.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @ezio-melotti ezio-melotti

    Labels
    docs Documentation in the Doc dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @bitdancer @ned-deily @ezio-melotti