Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeError in poplib.py #45435

Closed
sergejulien mannequin opened this issue Sep 3, 2007 · 3 comments
Closed

TypeError in poplib.py #45435

sergejulien mannequin opened this issue Sep 3, 2007 · 3 comments
Assignees
@gvanrossum
Labels
stdlib Python modules in the Lib dir

Comments

@sergejulien
Copy link
Mannequin

sergejulien mannequin commented Sep 3, 2007

BPO 1094
Nosy @gvanrossum
Files
  • poplib.diff
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/gvanrossum'
closed_at = <Date 2007-09-10.00:27:50.997>
created_at = <Date 2007-09-03.09:07:07.587>
labels = ['library']
title = 'TypeError in poplib.py'
updated_at = <Date 2007-09-10.00:27:50.970>
user = 'https://bugs.python.org/sergejulien'

    bugs.python.org fields:

    activity = <Date 2007-09-10.00:27:50.970>
actor = 'gvanrossum'
assignee = 'gvanrossum'
closed = True
closed_date = <Date 2007-09-10.00:27:50.997>
closer = 'gvanrossum'
components = ['Library (Lib)']
creation = <Date 2007-09-03.09:07:07.587>
creator = 'serge.julien'
dependencies = []
files = ['8412']
hgrepos = []
issue_num = 1094
keywords = ['patch']
message_count = 3.0
messages = ['55617', '55618', '55771']
nosy_count = 2.0
nosy_names = ['gvanrossum', 'serge.julien']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue1094'
versions = ['Python 3.0']
    @sergejulien
    Copy link
    Mannequin Author

    sergejulien mannequin commented Sep 3, 2007

    In poplib.py, lines 137-138, bytes and str are compared, leading to a
    TypeError:

    [...]
    137 while line != '.':
    138 if line[:2] == '..':
    [...]

    where type(line) = <type 'bytes'>

    @sergejulien sergejulien mannequin added the stdlib Python modules in the Lib dir label Sep 3, 2007
    @sergejulien
    Copy link
    Mannequin Author

    sergejulien mannequin commented Sep 3, 2007

    Patch proposal.

    Tell me if it's right to submit it here: this is the first patch I submit

    @gvanrossum
    Copy link
    Member

    Oops, I accidentally deleted the patch. Here is is again.
    Thanks for the patch! I've applied it.
    Committed revision 58072.

    @gvanrossum gvanrossum self-assigned this Sep 10, 2007
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @gvanrossum gvanrossum

    Labels
    stdlib Python modules in the Lib dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @gvanrossum