Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

distutils/test_sdist failure on windows #49335

Closed
ocean-city mannequin opened this issue Jan 27, 2009 · 2 comments
Closed

distutils/test_sdist failure on windows #49335

ocean-city mannequin opened this issue Jan 27, 2009 · 2 comments
Assignees
@tarekziade
Labels
tests Tests in the Lib/test dir

Comments

@ocean-city
Copy link
Mannequin

ocean-city mannequin commented Jan 27, 2009

BPO 5085
Nosy @tarekziade
Files
  • test_sdist_on_win32.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/tarekziade'
closed_at = <Date 2009-01-30.00:32:27.166>
created_at = <Date 2009-01-27.22:33:34.118>
labels = ['tests']
title = 'distutils/test_sdist failure on windows'
updated_at = <Date 2009-01-30.00:32:27.154>
user = 'https://bugs.python.org/ocean-city'

    bugs.python.org fields:

    activity = <Date 2009-01-30.00:32:27.154>
actor = 'tarek'
assignee = 'tarek'
closed = True
closed_date = <Date 2009-01-30.00:32:27.166>
closer = 'tarek'
components = ['Tests']
creation = <Date 2009-01-27.22:33:34.118>
creator = 'ocean-city'
dependencies = []
files = ['12881']
hgrepos = []
issue_num = 5085
keywords = ['patch']
message_count = 2.0
messages = ['80674', '80800']
nosy_count = 2.0
nosy_names = ['ocean-city', 'tarek']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue5085'
versions = ['Python 2.7']
    @ocean-city
    Copy link
    Mannequin Author

    ocean-city mannequin commented Jan 27, 2009

    test_sdist fails on windows with following message.

    http://www.python.org/dev/buildbot/trunk.stable/x86%20XP-4%
    20trunk/builds/1823/step-test/0

    ======================================================================
    ERROR: test_make_distribution (distutils.tests.test_sdist.sdistTestCase)
    ----------------------------------------------------------------------

    Traceback (most recent call last):
  File "E:\cygwin\home\db3l\buildarea\trunk.bolen-
windows\build\lib\distutils\tests\test_sdist.py", line 119, in 
test_make_distribution
    spawn('tar --help')
  File "E:\cygwin\home\db3l\buildarea\trunk.bolen-
windows\build\lib\distutils\spawn.py", line 37, in spawn
    _spawn_nt(cmd, search_path, dry_run=dry_run)
  File "E:\cygwin\home\db3l\buildarea\trunk.bolen-
windows\build\lib\distutils\spawn.py", line 70, in _spawn_nt
    cmd = _nt_quote_args(cmd)
  File "E:\cygwin\home\db3l\buildarea\trunk.bolen-
windows\build\lib\distutils\spawn.py", line 61, in _nt_quote_args
    args[i] = '"%s"' % args[i]
TypeError: 'str' object does not support item assignment

    ////////////////////////////////////

    This can be fixed if replace
    spawn('tar --help')
    in Lib/distutils/tests/test_sdist.py with
    spawn(['tar', '--help'])
    but, "tar --help" outputs very long message, it is not beautiful.

    So I'll push attached patch. (This also checks gzip
    which requres to run test)

    @ocean-city ocean-city mannequin added the tests Tests in the Lib/test dir label Jan 27, 2009
    @tarekziade
    Copy link
    Mannequin

    tarekziade mannequin commented Jan 30, 2009

    Just saw that issue, thanks, the bug was fixed some minutes ago.

    I came up with about the same fix, see r69106

    @tarekziade tarekziade mannequin closed this as completed Jan 30, 2009
    @tarekziade tarekziade mannequin self-assigned this Jan 30, 2009
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @tarekziade tarekziade

    Labels
    tests Tests in the Lib/test dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    0 participants