➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: distutils/test_sdist failure on windows
Type: Stage:
Components: Tests Versions: Python 2.7
process
Status: closed Resolution:
Dependencies: Superseder:
Assigned To: tarek Nosy List: ocean-city, tarek
Priority: normal Keywords: patch

Created on 2009-01-27 22:33 by ocean-city, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
test_sdist_on_win32.patch ocean-city, 2009-01-27 22:33
Messages (2)
msg80674 - (view) Author: Hirokazu Yamamoto (ocean-city) * (Python committer) Date: 2009-01-27 22:33 
test_sdist fails on windows with following message.

http://www.python.org/dev/buildbot/trunk.stable/x86%20XP-4%
20trunk/builds/1823/step-test/0

======================================================================
ERROR: test_make_distribution (distutils.tests.test_sdist.sdistTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "E:\cygwin\home\db3l\buildarea\trunk.bolen-
windows\build\lib\distutils\tests\test_sdist.py", line 119, in 
test_make_distribution
    spawn('tar --help')
  File "E:\cygwin\home\db3l\buildarea\trunk.bolen-
windows\build\lib\distutils\spawn.py", line 37, in spawn
    _spawn_nt(cmd, search_path, dry_run=dry_run)
  File "E:\cygwin\home\db3l\buildarea\trunk.bolen-
windows\build\lib\distutils\spawn.py", line 70, in _spawn_nt
    cmd = _nt_quote_args(cmd)
  File "E:\cygwin\home\db3l\buildarea\trunk.bolen-
windows\build\lib\distutils\spawn.py", line 61, in _nt_quote_args
    args[i] = '"%s"' % args[i]
TypeError: 'str' object does not support item assignment

////////////////////////////////////

This can be fixed if replace
  spawn('tar --help')
in Lib/distutils/tests/test_sdist.py with
  spawn(['tar', '--help'])
but, "tar --help" outputs very long message, it is not beautiful.

So I'll push attached patch. (This also checks gzip
which requres to run test)
msg80800 - (view) Author: Tarek Ziadé (tarek) * (Python committer) Date: 2009-01-30 00:32 
Just saw that issue, thanks, the bug was fixed some minutes ago.

I came up with about the same fix, see r69106
History
Date User Action Args
2022-04-11 14:56:44adminsetgithub: 49335
2009-01-30 00:32:27tareksetstatus: open -> closed
assignee: tarek
messages: + msg80800
nosy: + tarek
2009-01-27 22:33:34ocean-citycreate