Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Directory.Build.props/targets leaks from folders above the repo #90089

Closed
dfederm mannequin opened this issue Nov 29, 2021 · 6 comments
Closed

Directory.Build.props/targets leaks from folders above the repo #90089

dfederm mannequin opened this issue Nov 29, 2021 · 6 comments
Labels
3.9 only security fixes 3.10 only security fixes 3.11 only security fixes build The build process and cross-build OS-windows

Comments

@dfederm
Copy link
Mannequin

dfederm mannequin commented Nov 29, 2021

BPO 45931
Nosy @pfmoore, @tjguk, @zware, @zooba, @miss-islington, @dfederm
PRs
  • bpo-45931: Prevent Directory.Build.props/targets from leaking from directories above the repo #29854
  • [3.10] bpo-45931: Prevent Directory.Build.props/targets from leaking from directories above the repo when building on Windows (GH-29854) #29855
  • [3.9] bpo-45931: Prevent Directory.Build.props/targets from leaking from directories above the repo when building on Windows (GH-29854) #29856
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2021-11-29.23:06:25.506>
created_at = <Date 2021-11-29.19:43:33.801>
labels = ['3.10', 'build', '3.9', 'OS-windows', '3.11']
title = 'Directory.Build.props/targets leaks from folders above the repo'
updated_at = <Date 2021-11-29.23:08:57.143>
user = 'https://github.com/dfederm'

    bugs.python.org fields:

    activity = <Date 2021-11-29.23:08:57.143>
actor = 'miss-islington'
assignee = 'none'
closed = True
closed_date = <Date 2021-11-29.23:06:25.506>
closer = 'steve.dower'
components = ['Build', 'Windows']
creation = <Date 2021-11-29.19:43:33.801>
creator = 'dfederm'
dependencies = []
files = []
hgrepos = []
issue_num = 45931
keywords = ['patch']
message_count = 6.0
messages = ['407320', '407325', '407331', '407332', '407333', '407334']
nosy_count = 6.0
nosy_names = ['paul.moore', 'tim.golden', 'zach.ware', 'steve.dower', 'miss-islington', 'dfederm']
pr_nums = ['29854', '29855', '29856']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue45931'
versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']
    @dfederm
    Copy link
    Mannequin Author

    dfederm mannequin commented Nov 29, 2021

    When building with Visual Studio 2017+, any Directory.Build.props/targets above the repo in the file structure (eg. in the parent repo when the python repo is a submodule) will be imported automatically.

    @dfederm dfederm mannequin added 3.11 only security fixes build The build process and cross-build labels Nov 29, 2021
    @zooba
    Copy link
    Member

    zooba commented Nov 29, 2021

    Nice catch, thanks!

    Did you start the CLA process already? (I personally would exempt this PR from it as "not sufficiently creative", but I'm not sure I'm allowed to do that anymore...)

    @zooba
    Copy link
    Member

    zooba commented Nov 29, 2021

    New changeset 734ed35 by David Federman in branch 'main':
    bpo-45931: Prevent Directory.Build.props/targets from leaking from directories above the repo when building on Windows (GH-29854)
    734ed35

    @zooba
    Copy link
    Member

    zooba commented Nov 29, 2021

    Looks like it's gone through. Thanks!

    @zooba zooba added 3.9 only security fixes 3.10 only security fixes labels Nov 29, 2021
    @zooba zooba closed this as completed Nov 29, 2021
    @zooba zooba closed this as completed Nov 29, 2021
    @miss-islington
    Copy link
    Contributor

    New changeset 5a6d9ed by Miss Islington (bot) in branch '3.10':
    bpo-45931: Prevent Directory.Build.props/targets from leaking from directories above the repo when building on Windows (GH-29854)
    5a6d9ed

    @miss-islington
    Copy link
    Contributor

    New changeset b91805e by Miss Islington (bot) in branch '3.9':
    bpo-45931: Prevent Directory.Build.props/targets from leaking from directories above the repo when building on Windows (GH-29854)
    b91805e

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.9 only security fixes 3.10 only security fixes 3.11 only security fixes build The build process and cross-build OS-windows
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @ericvsmith @zooba @miss-islington