Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FrameObject uses the old trashcan macros #89035

Closed
iritkatriel opened this issue Aug 9, 2021 · 6 comments
Closed

FrameObject uses the old trashcan macros #89035

iritkatriel opened this issue Aug 9, 2021 · 6 comments
Labels
3.8 only security fixes 3.9 only security fixes 3.10 only security fixes 3.11 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs)

Comments

@iritkatriel
Copy link
Member

BPO 44872
Nosy @ambv, @iritkatriel
PRs
  • bpo-44872: use new trashcan macros in framobject.c #27683
  • [3.10] bpo-44872: use new trashcan macros in framobject.c (GH-27683) #27690
  • [3.9] bpo-44872: use new trashcan macros in framobject.c (GH-27683) #27691
  • [3.8] bpo-44872: use new trashcan macros in framobject.c (GH-27683) #27692
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2021-08-10.07:56:46.325>
created_at = <Date 2021-08-09.16:12:13.222>
labels = ['interpreter-core', '3.8', '3.9', '3.10', '3.11']
title = 'FrameObject uses the old trashcan macros'
updated_at = <Date 2021-08-10.07:56:46.325>
user = 'https://github.com/iritkatriel'

    bugs.python.org fields:

    activity = <Date 2021-08-10.07:56:46.325>
actor = 'lukasz.langa'
assignee = 'none'
closed = True
closed_date = <Date 2021-08-10.07:56:46.325>
closer = 'lukasz.langa'
components = ['Interpreter Core']
creation = <Date 2021-08-09.16:12:13.222>
creator = 'iritkatriel'
dependencies = []
files = []
hgrepos = []
issue_num = 44872
keywords = ['patch']
message_count = 6.0
messages = ['399274', '399280', '399302', '399303', '399304', '399305']
nosy_count = 2.0
nosy_names = ['lukasz.langa', 'iritkatriel']
pr_nums = ['27683', '27690', '27691', '27692']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue44872'
versions = ['Python 3.8', 'Python 3.9', 'Python 3.10', 'Python 3.11']
    @iritkatriel
    Copy link
    Member Author

    Py_TRASHCAN_SAFE_BEGIN/END are the old macros, and they are currently broken (see bpo-40608). We should use Py_TRASHCAN_BEGIN/END instead.

    @iritkatriel iritkatriel added 3.10 only security fixes 3.11 only security fixes 3.9 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Aug 9, 2021
    @iritkatriel
    Copy link
    Member Author

    New changeset 7d14fdb by Irit Katriel in branch 'main':
    bpo-44872: use new trashcan macros in framobject.c (bpo-27683)
    7d14fdb

    @iritkatriel iritkatriel added 3.8 only security fixes labels Aug 9, 2021
    @ambv
    Copy link
    Contributor

    ambv commented Aug 10, 2021

    New changeset ede1dc4 by Irit Katriel in branch '3.9':
    bpo-44872: use new trashcan macros in framobject.c (GH-27683) (GH-27691)
    ede1dc4

    @ambv
    Copy link
    Contributor

    ambv commented Aug 10, 2021

    New changeset b019ffe by Irit Katriel in branch '3.8':
    bpo-44872: use new trashcan macros in framobject.c (GH-27683) (GH-27692)
    b019ffe

    @ambv
    Copy link
    Contributor

    ambv commented Aug 10, 2021

    New changeset e9ec71a by Irit Katriel in branch '3.10':
    bpo-44872: use new trashcan macros in framobject.c (GH-27683) (GH-27690)
    e9ec71a

    @ambv
    Copy link
    Contributor

    ambv commented Aug 10, 2021

    Thanks, Irit! ✨ 🍰 ✨

    @ambv ambv closed this as completed Aug 10, 2021
    @ambv ambv closed this as completed Aug 10, 2021
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.8 only security fixes 3.9 only security fixes 3.10 only security fixes 3.11 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs)
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @ambv @iritkatriel