classification
Title: FrameObject uses the old trashcan macros
Type: Stage: resolved
Components: Interpreter Core Versions: Python 3.11, Python 3.10, Python 3.9, Python 3.8
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: iritkatriel, lukasz.langa
Priority: normal Keywords: patch

Created on 2021-08-09 16:12 by iritkatriel, last changed 2021-08-10 07:56 by lukasz.langa. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 27683 merged iritkatriel, 2021-08-09 16:14
PR 27690 merged iritkatriel, 2021-08-09 18:24
PR 27691 merged iritkatriel, 2021-08-09 18:37
PR 27692 merged iritkatriel, 2021-08-09 18:49
Messages (6)
msg399274 - (view) Author: Irit Katriel (iritkatriel) * (Python committer) Date: 2021-08-09 16:12
Py_TRASHCAN_SAFE_BEGIN/END are the old macros, and they are currently broken (see Issue40608). We should use Py_TRASHCAN_BEGIN/END instead.
msg399280 - (view) Author: Irit Katriel (iritkatriel) * (Python committer) Date: 2021-08-09 17:11
New changeset 7d14fdb03c3e8384c01da1b21647ce837ed6a29c by Irit Katriel in branch 'main':
bpo-44872: use new trashcan macros in framobject.c (#27683)
https://github.com/python/cpython/commit/7d14fdb03c3e8384c01da1b21647ce837ed6a29c
msg399302 - (view) Author: Łukasz Langa (lukasz.langa) * (Python committer) Date: 2021-08-10 07:55
New changeset ede1dc416de5eece02170e03387dc8496c2d00ae by Irit Katriel in branch '3.9':
bpo-44872: use new trashcan macros in framobject.c (GH-27683) (GH-27691)
https://github.com/python/cpython/commit/ede1dc416de5eece02170e03387dc8496c2d00ae
msg399303 - (view) Author: Łukasz Langa (lukasz.langa) * (Python committer) Date: 2021-08-10 07:55
New changeset b019ffed5debb13358a946a8e2d20594c7c181f3 by Irit Katriel in branch '3.8':
bpo-44872: use new trashcan macros in framobject.c (GH-27683) (GH-27692)
https://github.com/python/cpython/commit/b019ffed5debb13358a946a8e2d20594c7c181f3
msg399304 - (view) Author: Łukasz Langa (lukasz.langa) * (Python committer) Date: 2021-08-10 07:56
New changeset e9ec71ad2c7a1c83f03e172ba7c9f534912b8ba6 by Irit Katriel in branch '3.10':
bpo-44872: use new trashcan macros in framobject.c (GH-27683) (GH-27690)
https://github.com/python/cpython/commit/e9ec71ad2c7a1c83f03e172ba7c9f534912b8ba6
msg399305 - (view) Author: Łukasz Langa (lukasz.langa) * (Python committer) Date: 2021-08-10 07:56
Thanks, Irit! ✨ 🍰 ✨
History
Date User Action Args
2021-08-10 07:56:46lukasz.langasetstatus: open -> closed
resolution: fixed
messages: + msg399305

stage: patch review -> resolved
2021-08-10 07:56:18lukasz.langasetmessages: + msg399304
2021-08-10 07:55:49lukasz.langasetmessages: + msg399303
2021-08-10 07:55:46lukasz.langasetmessages: + msg399302
2021-08-09 18:49:25iritkatrielsetpull_requests: + pull_request26178
2021-08-09 18:39:37iritkatrielsetnosy: + lukasz.langa
2021-08-09 18:39:22iritkatrielsetversions: + Python 3.8
2021-08-09 18:37:02iritkatrielsetpull_requests: + pull_request26177
2021-08-09 18:24:58iritkatrielsetpull_requests: + pull_request26176
2021-08-09 17:11:46iritkatrielsetmessages: + msg399280
2021-08-09 16:14:17iritkatrielsetkeywords: + patch
stage: patch review
pull_requests: + pull_request26169
2021-08-09 16:12:13iritkatrielcreate