Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some configure checks rely on implicit function declaration #86764

Closed
jmroot mannequin opened this issue Dec 8, 2020 · 5 comments
Closed

Some configure checks rely on implicit function declaration #86764

jmroot mannequin opened this issue Dec 8, 2020 · 5 comments
Labels
3.8 only security fixes 3.9 only security fixes 3.10 only security fixes build The build process and cross-build

Comments

@jmroot
Copy link
Mannequin

jmroot mannequin commented Dec 8, 2020

BPO 42598
Nosy @ned-deily, @jmroot, @miss-islington
PRs
  • bpo-42598: Fix implicit function declarations in configure #23690
  • [3.9] bpo-42598: Fix implicit function declarations in configure (GH-23690) #23756
  • [3.8] bpo-42598: Fix implicit function declarations in configure (GH-23690) #23757
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2020-12-13.22:04:41.999>
created_at = <Date 2020-12-08.11:15:17.229>
labels = ['build', '3.8', '3.9', '3.10']
title = 'Some configure checks rely on implicit function declaration'
updated_at = <Date 2020-12-13.22:04:41.995>
user = 'https://github.com/jmroot'

    bugs.python.org fields:

    activity = <Date 2020-12-13.22:04:41.995>
actor = 'ned.deily'
assignee = 'none'
closed = True
closed_date = <Date 2020-12-13.22:04:41.999>
closer = 'ned.deily'
components = ['Build']
creation = <Date 2020-12-08.11:15:17.229>
creator = 'jmr'
dependencies = []
files = []
hgrepos = []
issue_num = 42598
keywords = ['patch']
message_count = 5.0
messages = ['382726', '382940', '382941', '382942', '382943']
nosy_count = 3.0
nosy_names = ['ned.deily', 'jmr', 'miss-islington']
pr_nums = ['23690', '23756', '23757']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue42598'
versions = ['Python 3.8', 'Python 3.9', 'Python 3.10']
    @jmroot
    Copy link
    Mannequin Author

    jmroot mannequin commented Dec 8, 2020

    There are several cases in the configure script of exit being used without including stdlib.h, and one case of close being used without including unistd.h. A compiler that does not allow implicit function declaration, such as clang in Xcode 12, will error out due to this, which may cause the affected checks to give incorrect results.

    @jmroot jmroot mannequin added 3.10 only security fixes 3.9 only security fixes build The build process and cross-build labels Dec 8, 2020
    @ned-deily
    Copy link
    Member

    New changeset 674fa0a by Joshua Root in branch 'master':
    bpo-42598: Fix implicit function declarations in configure (GH-23690)
    674fa0a

    @ned-deily
    Copy link
    Member

    New changeset 3dcdbde by Miss Islington (bot) in branch '3.9':
    bpo-42598: Fix implicit function declarations in configure (GH-23690) (GH-23756)
    3dcdbde

    @ned-deily
    Copy link
    Member

    New changeset 9feda9f by Miss Islington (bot) in branch '3.8':
    bpo-42598: Fix implicit function declarations in configure (GH-23690) (GH-23757)
    9feda9f

    @ned-deily
    Copy link
    Member

    Thanks for noticing the failures and for the PR!

    @ned-deily ned-deily added the 3.8 only security fixes label Dec 13, 2020
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.8 only security fixes 3.9 only security fixes 3.10 only security fixes build The build process and cross-build
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @ned-deily