Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bundled pip to 20.1.1 #82669

Closed
xavfernandez mannequin opened this issue Oct 15, 2019 · 9 comments
Closed

Update bundled pip to 20.1.1 #82669

xavfernandez mannequin opened this issue Oct 15, 2019 · 9 comments
Labels
3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes 3.10 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@xavfernandez
Copy link
Mannequin

xavfernandez mannequin commented Oct 15, 2019

BPO 38488
Nosy @vstinner, @ned-deily, @The-Compiler, @miss-islington, @xavfernandez
PRs
  • bpo-38488: Upgrade bundled versions of pip & setuptools #16782
  • Revert "bpo-38488: Upgrade bundled versions of pip & setuptools" #20484
  • bpo-38488: Upgrade bundled versions of pip & setuptools #20491
  • [3.9] bpo-38488: Upgrade bundled versions of pip & setuptools (GH-20491) #20898
  • [3.8] bpo-38488: Upgrade bundled versions of pip & setuptools (GH-20491) #20900
  • [3.7] bpo-38488: Upgrade bundled versions of pip & setuptools (GH-20491) (GH-20900) #20902
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2020-06-15.23:05:58.964>
created_at = <Date 2019-10-15.21:19:42.779>
labels = ['3.7', '3.8', '3.9', '3.10', 'type-feature', 'library']
title = 'Update bundled pip to 20.1.1'
updated_at = <Date 2020-06-15.23:05:58.955>
user = 'https://github.com/xavfernandez'

    bugs.python.org fields:

    activity = <Date 2020-06-15.23:05:58.955>
actor = 'ned.deily'
assignee = 'none'
closed = True
closed_date = <Date 2020-06-15.23:05:58.964>
closer = 'ned.deily'
components = ['Library (Lib)']
creation = <Date 2019-10-15.21:19:42.779>
creator = 'Xavier Fernandez'
dependencies = []
files = []
hgrepos = []
issue_num = 38488
keywords = ['patch']
message_count = 9.0
messages = ['370204', '370210', '370211', '370213', '371587', '371596', '371598', '371599', '371603']
nosy_count = 5.0
nosy_names = ['vstinner', 'ned.deily', 'The Compiler', 'miss-islington', 'Xavier Fernandez']
pr_nums = ['16782', '20484', '20491', '20898', '20900', '20902']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue38488'
versions = ['Python 3.7', 'Python 3.8', 'Python 3.9', 'Python 3.10']
    @xavfernandez xavfernandez mannequin added stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels Oct 15, 2019
    @vstinner
    Copy link
    Member

    Various buildbots which run the tests with an installed python, fail with: (...)

    It's the "chmod" step which fails. I guess that only "Install" buildbot workers are affected. I failed to reproduce the issue with commands:
    ---
    ./configure --prefix $PWD/target --with-pydebug
    make && make install
    chmod -R -w target/
    ---

    I get these permissions:
    ---

    $ ls -l target/lib/python3.10/site-packages/setuptools-46.1.3.dist-info/RECORD
-r--r--r--. 1 vstinner vstinner 14560 28 mai   03:40 target/lib/python3.10/site-packages/setuptools-46.1.3.dist-info/RECORD

    @vstinner
    Copy link
    Member

    commit feb0846
    Author: Xavier Fernandez <xav.fernandez@gmail.com>
    Date: Wed May 27 12:49:34 2020 +0200

    Upgrade bundled versions of pip & setuptools (bpo-16782)

    @vstinner
    Copy link
    Member

    This commit introduced another regression, bpo-40808: test_venv fails with HOME=/ on AMD64 FreeBSD Non-Debug 3.x.

    @vstinner
    Copy link
    Member

    The change broke multiple buildbots. Since nobody is available to investigate the two regressions (install buildbots and test_venv), I reverted the change following this policy:
    https://pythondev.readthedocs.io/ci.html#revert-on-fail

    Buildbot failures were reported directly the on PR, see:
    #16782 (comment)

    The revert is an opportunity to have more time to investigate the issue and write a proper fix, rather than working on urgency.

    commit 4fd4963 (HEAD -> master, upstream/master)
    Author: Victor Stinner <vstinner@python.org>
    Date: Thu May 28 15:57:49 2020 +0200

    Revert "Upgrade bundled versions of pip & setuptools (bpo-16782)" (GH-20484)

This reverts commit feb0846c3a28b05b4cfbc6ab34c764957f3eff55.

    @ned-deily
    Copy link
    Member

    New changeset 5f79f46 by Xavier Fernandez in branch 'master':
    bpo-38488: Upgrade bundled versions of pip & setuptools (GH-20491)
    5f79f46

    @miss-islington
    Copy link
    Contributor

    New changeset bc996c6 by Miss Islington (bot) in branch '3.9':
    bpo-38488: Upgrade bundled versions of pip & setuptools (GH-20491)
    bc996c6

    @ned-deily
    Copy link
    Member

    New changeset e63cc2f by Ned Deily in branch '3.8':
    bpo-38488: Upgrade bundled versions of pip & setuptools (GH-20491) (GH-20900)
    e63cc2f

    @miss-islington
    Copy link
    Contributor

    New changeset 678ffc4 by Miss Islington (bot) in branch '3.7':
    bpo-38488: Upgrade bundled versions of pip & setuptools (GH-20491) (GH-20900)
    678ffc4

    @ned-deily
    Copy link
    Member

    Thanks, Xavier, for the original PR and for the various requested updates! And thanks everyone else for the reviews and follow-ups. Merged for release in 3.9.0, 3.8.4, and 3.7.8.

    @ned-deily ned-deily added 3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes 3.10 only security fixes labels Jun 15, 2020
    @ned-deily ned-deily changed the title Update bundled pip to 19.3 Update bundled pip to 20.1.1 Jun 15, 2020
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes 3.10 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @vstinner @ned-deily @miss-islington