Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make select module PEP-384 compatible #82297

Closed
DinoV opened this issue Sep 11, 2019 · 6 comments
Closed

Make select module PEP-384 compatible #82297

DinoV opened this issue Sep 11, 2019 · 6 comments
Assignees
@DinoV
Labels
3.9 only security fixes extension-modules C modules in the Modules dir type-feature A feature request or enhancement

Comments

@DinoV
Copy link
Contributor

DinoV commented Sep 11, 2019

BPO 38116
Nosy @vstinner, @tiran, @phsilva, @DinoV, @ericsnowcurrently, @MojoVampire, @isidentical
PRs
  • bpo-38116: Convert select module to PEP-384 #15971
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/DinoV'
closed_at = <Date 2020-06-22.09:14:47.516>
created_at = <Date 2019-09-11.14:48:15.345>
labels = ['extension-modules', 'type-feature', '3.9']
title = 'Make select module PEP-384 compatible'
updated_at = <Date 2020-06-22.09:28:51.858>
user = 'https://github.com/DinoV'

    bugs.python.org fields:

    activity = <Date 2020-06-22.09:28:51.858>
actor = 'vstinner'
assignee = 'dino.viehland'
closed = True
closed_date = <Date 2020-06-22.09:14:47.516>
closer = 'vstinner'
components = ['Extension Modules']
creation = <Date 2019-09-11.14:48:15.345>
creator = 'dino.viehland'
dependencies = []
files = []
hgrepos = []
issue_num = 38116
keywords = ['patch']
message_count = 6.0
messages = ['351913', '352017', '352431', '356825', '372058', '372070']
nosy_count = 7.0
nosy_names = ['vstinner', 'christian.heimes', 'phsilva', 'dino.viehland', 'eric.snow', 'josh.r', 'BTaskaya']
pr_nums = ['15971']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue38116'
versions = ['Python 3.9']
    @DinoV
    Copy link
    Contributor Author

    DinoV commented Sep 11, 2019

    Remove static PyTypeObject* definitions and move static data to _selectstate to help improve compatibility w/ subinterpreters and re-use by alternate implementations.

    @DinoV DinoV added the 3.9 only security fixes label Sep 11, 2019
    @DinoV DinoV self-assigned this Sep 11, 2019
    @DinoV DinoV added the extension-modules C modules in the Modules dir label Sep 11, 2019
    @tiran tiran added the type-feature A feature request or enhancement label Sep 11, 2019
    @MojoVampire
    Copy link
    Mannequin

    MojoVampire mannequin commented Sep 11, 2019

    Why do you describe these issues (this one, bpo-38069, bpo-38071-bpo-38076, maybe more) as making the module PEP-384 compatible? There is no reason to make the built-in modules stick to the limited API, and it doesn't look like you're doing that in any event (among other things, pretty sure Argument Clinic generated code isn't limited API compatible yet, though that might be changing?).

    Seems like the main (only?) change you're making is to convert all static types to dynamic types. Which is fine, if it's necessary for PEP-554, but it seems only loosely related to PEP-384 (which defined mechanisms for "statically" defining dynamic heap types, but that wasn't the main thrust).

    @DinoV
    Copy link
    Contributor Author

    DinoV commented Sep 14, 2019

    New changeset f919054 by Dino Viehland in branch 'master':
    bpo-38116: Convert select module to PEP-384 (bpo-15971)
    f919054

    @isidentical
    Copy link
    Sponsor Member

    PR 15971 is merged, what else is needed @dino.viehland?

    @vstinner
    Copy link
    Member

    PR 15971 is merged, what else is needed @dino.viehland?

    Nothing, I close the issue.

    @vstinner
    Copy link
    Member

    I marked bpo-15703 as a duplicate of this issue.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @DinoV DinoV

    Labels
    3.9 only security fixes extension-modules C modules in the Modules dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    4 participants
    @vstinner @DinoV @tiran @isidentical