classification
Title: Make select module PEP-384 compatible
Type: enhancement Stage: patch review
Components: Extension Modules Versions: Python 3.9
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: dino.viehland Nosy List: BTaskaya, christian.heimes, dino.viehland, eric.snow, josh.r, phsilva
Priority: normal Keywords: patch

Created on 2019-09-11 14:48 by dino.viehland, last changed 2019-11-17 18:37 by BTaskaya.

Pull Requests
URL Status Linked Edit
PR 15971 merged dino.viehland, 2019-09-11 14:49
Messages (4)
msg351913 - (view) Author: Dino Viehland (dino.viehland) * (Python committer) Date: 2019-09-11 14:48
Remove static PyTypeObject* definitions and move static data to _selectstate to help improve compatibility w/ subinterpreters and re-use by alternate implementations.
msg352017 - (view) Author: Josh Rosenberg (josh.r) * (Python triager) Date: 2019-09-11 19:09
Why do you describe these issues (this one, #38069, #38071-#38076, maybe more) as making the module PEP 384 compatible? There is no reason to make the built-in modules stick to the limited API, and it doesn't look like you're doing that in any event (among other things, pretty sure Argument Clinic generated code isn't limited API compatible yet, though that might be changing?).

Seems like the main (only?) change you're making is to convert all static types to dynamic types. Which is fine, if it's necessary for PEP 554, but it seems only loosely related to PEP 384 (which defined mechanisms for "statically" defining dynamic heap types, but that wasn't the main thrust).
msg352431 - (view) Author: Dino Viehland (dino.viehland) * (Python committer) Date: 2019-09-14 14:20
New changeset f919054e539a5c1afde1b31c9fd7a8f5b2313311 by Dino Viehland in branch 'master':
bpo-38116: Convert select module to PEP-384 (#15971)
https://github.com/python/cpython/commit/f919054e539a5c1afde1b31c9fd7a8f5b2313311
msg356825 - (view) Author: Batuhan (BTaskaya) * Date: 2019-11-17 18:37
PR 15971 is merged, what else is needed @dino.viehland?
History
Date User Action Args
2019-11-17 18:37:57BTaskayasetnosy: + BTaskaya
messages: + msg356825
2019-09-19 04:03:39phsilvasetnosy: + phsilva
2019-09-14 14:20:30dino.viehlandsetmessages: + msg352431
2019-09-11 19:09:45josh.rsetnosy: + josh.r
messages: + msg352017
2019-09-11 18:00:44christian.heimessetnosy: + christian.heimes
type: enhancement
2019-09-11 14:49:01dino.viehlandsetkeywords: + patch
stage: patch review
pull_requests: + pull_request15604
2019-09-11 14:48:15dino.viehlandcreate