Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update_one_slot() should not ignore wrapper descriptors for wrong type #81800

Closed
jdemeyer opened this issue Jul 18, 2019 · 4 comments
Closed

update_one_slot() should not ignore wrapper descriptors for wrong type #81800

jdemeyer opened this issue Jul 18, 2019 · 4 comments
Labels
3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs)

Comments

@jdemeyer
Copy link
Contributor

BPO 37619
Nosy @Yhg1s, @jdemeyer
PRs
  • bpo-37619: don't ignore wrapper descriptors for wrong class #14836
  • [3.8] bpo-37619: update_one_slot() should not ignore wrapper descriptors for wrong type (GH-14836) #15838
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2019-09-10.13:03:16.765>
created_at = <Date 2019-07-18.09:04:18.404>
labels = ['interpreter-core', '3.7', '3.8', '3.9']
title = 'update_one_slot() should not ignore wrapper descriptors for wrong type'
updated_at = <Date 2019-09-10.13:03:16.764>
user = 'https://github.com/jdemeyer'

    bugs.python.org fields:

    activity = <Date 2019-09-10.13:03:16.764>
actor = 'twouters'
assignee = 'none'
closed = True
closed_date = <Date 2019-09-10.13:03:16.765>
closer = 'twouters'
components = ['Interpreter Core']
creation = <Date 2019-07-18.09:04:18.404>
creator = 'jdemeyer'
dependencies = []
files = []
hgrepos = []
issue_num = 37619
keywords = ['patch']
message_count = 4.0
messages = ['348108', '351623', '351633', '351637']
nosy_count = 2.0
nosy_names = ['twouters', 'jdemeyer']
pr_nums = ['14836', '15838']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue37619'
versions = ['Python 2.7', 'Python 3.5', 'Python 3.6', 'Python 3.7', 'Python 3.8', 'Python 3.9']
    @jdemeyer
    Copy link
    Contributor Author 

    >>> class S(str):
...     __eq__ = int.__eq__
>>> S() == S()
True

    The expectation is that this raises an exception because int.__eq__() is called on S instances.

    @jdemeyer jdemeyer added 3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Jul 18, 2019
    @Yhg1s
    Copy link
    Member

    Yhg1s commented Sep 10, 2019

    New changeset 57ea335 by T. Wouters (Jeroen Demeyer) in branch 'master':
    bpo-37619: update_one_slot() should not ignore wrapper descriptors for wrong type (GH-14836)
    57ea335

    @Yhg1s
    Copy link
    Member

    Yhg1s commented Sep 10, 2019

    New changeset eb1bc48 by T. Wouters (Miss Islington (bot)) in branch '3.8':
    bpo-37619: update_one_slot() should not ignore wrapper descriptors for wrong type (GH-15838)
    eb1bc48

    @Yhg1s
    Copy link
    Member

    Yhg1s commented Sep 10, 2019

    I don't think this should be backported to 3.7 at this point; if you disagree feel free to reopen the bug.

    @Yhg1s Yhg1s closed this as completed Sep 10, 2019
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs)
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @jdemeyer @Yhg1s