classification
Title: update_one_slot() should not ignore wrapper descriptors for wrong type
Type: Stage: resolved
Components: Interpreter Core Versions: Python 3.9, Python 3.8, Python 3.7, Python 3.6, Python 3.5, Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: jdemeyer, twouters
Priority: normal Keywords: patch

Created on 2019-07-18 09:04 by jdemeyer, last changed 2019-09-10 13:03 by twouters. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 14836 merged jdemeyer, 2019-07-18 09:54
PR 15838 merged miss-islington, 2019-09-10 11:22
Messages (4)
msg348108 - (view) Author: Jeroen Demeyer (jdemeyer) * (Python triager) Date: 2019-07-18 09:04
>>> class S(str):
...     __eq__ = int.__eq__
>>> S() == S()
True

The expectation is that this raises an exception because int.__eq__() is called on S instances.
msg351623 - (view) Author: Thomas Wouters (twouters) * (Python committer) Date: 2019-09-10 11:21
New changeset 57ea33560662e0f20a3b0334bb20065771edf4da by T. Wouters (Jeroen Demeyer) in branch 'master':
bpo-37619: update_one_slot() should not ignore wrapper descriptors for wrong type (GH-14836)
https://github.com/python/cpython/commit/57ea33560662e0f20a3b0334bb20065771edf4da
msg351633 - (view) Author: Thomas Wouters (twouters) * (Python committer) Date: 2019-09-10 12:55
New changeset eb1bc48c74f4f8af88b5276729f9652201e46324 by T. Wouters (Miss Islington (bot)) in branch '3.8':
bpo-37619: update_one_slot() should not ignore wrapper descriptors for wrong type (GH-15838)
https://github.com/python/cpython/commit/eb1bc48c74f4f8af88b5276729f9652201e46324
msg351637 - (view) Author: Thomas Wouters (twouters) * (Python committer) Date: 2019-09-10 13:03
I don't think this should be backported to 3.7 at this point; if you disagree feel free to reopen the bug.
History
Date User Action Args
2019-09-10 13:03:16twouterssetstatus: open -> closed
resolution: fixed
messages: + msg351637

stage: patch review -> resolved
2019-09-10 12:55:14twouterssetmessages: + msg351633
2019-09-10 11:22:09miss-islingtonsetpull_requests: + pull_request15483
2019-09-10 11:21:59twouterssetnosy: + twouters
messages: + msg351623
2019-07-18 09:54:27jdemeyersetkeywords: + patch
stage: patch review
pull_requests: + pull_request14627
2019-07-18 09:04:18jdemeyercreate