Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forbid creating of stream objects outside of asyncio #80987

Closed
asvetlov opened this issue May 5, 2019 · 1 comment
Closed

Forbid creating of stream objects outside of asyncio #80987

asvetlov opened this issue May 5, 2019 · 1 comment
Labels
3.8 only security fixes topic-asyncio

Comments

@asvetlov
Copy link
Contributor

asvetlov commented May 5, 2019

BPO 36806
Nosy @asvetlov, @1st1
PRs
  • bpo-36806: Forbid stream objects creation outside of asyncio #13101
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2019-05-07.02:54:08.635>
created_at = <Date 2019-05-05.19:15:37.730>
labels = ['3.8', 'expert-asyncio']
title = 'Forbid creating of stream objects outside of asyncio'
updated_at = <Date 2019-05-07.02:54:08.632>
user = 'https://github.com/asvetlov'

    bugs.python.org fields:

    activity = <Date 2019-05-07.02:54:08.632>
actor = 'asvetlov'
assignee = 'none'
closed = True
closed_date = <Date 2019-05-07.02:54:08.635>
closer = 'asvetlov'
components = ['asyncio']
creation = <Date 2019-05-05.19:15:37.730>
creator = 'asvetlov'
dependencies = []
files = []
hgrepos = []
issue_num = 36806
keywords = ['patch']
message_count = 1.0
messages = ['341472']
nosy_count = 2.0
nosy_names = ['asvetlov', 'yselivanov']
pr_nums = ['13101']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue36806'
versions = ['Python 3.8']
    @asvetlov
    Copy link
    Contributor Author

    asvetlov commented May 5, 2019

    They were intended to be used by asyncio factories like open_connection from the very beginning but internals was leaked into asyncio top-level namespace.

    The idea is:

    1. provide _asyncio_internal keyword-only parameter to leaked classes constructor
    2. have it False by default
    3. Use _asyncio_internal=True when called from asyncio code.
    4. Raise DeprecationWarning if _asyncio_internal is False

    @asvetlov asvetlov added 3.8 only security fixes topic-asyncio labels May 5, 2019
    @asvetlov asvetlov closed this as completed May 7, 2019
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.8 only security fixes topic-asyncio
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @asvetlov