Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove fgBg param of idlelib.config.GetHighlight() #80577

Closed
terryjreedy opened this issue Mar 22, 2019 · 4 comments
Closed

Remove fgBg param of idlelib.config.GetHighlight() #80577

terryjreedy opened this issue Mar 22, 2019 · 4 comments
Assignees
@terryjreedy
Labels
3.7 (EOL) end of life 3.8 only security fixes topic-IDLE type-feature A feature request or enhancement

Comments

@terryjreedy
Copy link
Member

BPO 36396
Nosy @terryjreedy, @miss-islington
PRs
  • bpo-36396: Remove fgBg param of idlelib.config.GetHighlight() #12491
  • [3.7] bpo-36396: Remove fgBg param of idlelib.config.GetHighlight() (GH-12491) #12501
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/terryjreedy'
closed_at = <Date 2019-03-22.23:17:05.210>
created_at = <Date 2019-03-22.02:39:03.650>
labels = ['3.8', 'expert-IDLE', 'type-feature', '3.7']
title = 'Remove fgBg param of idlelib.config.GetHighlight()'
updated_at = <Date 2019-03-22.23:17:05.210>
user = 'https://github.com/terryjreedy'

    bugs.python.org fields:

    activity = <Date 2019-03-22.23:17:05.210>
actor = 'terry.reedy'
assignee = 'terry.reedy'
closed = True
closed_date = <Date 2019-03-22.23:17:05.210>
closer = 'terry.reedy'
components = ['IDLE']
creation = <Date 2019-03-22.02:39:03.650>
creator = 'terry.reedy'
dependencies = []
files = []
hgrepos = []
issue_num = 36396
keywords = ['patch']
message_count = 4.0
messages = ['338580', '338585', '338619', '338620']
nosy_count = 2.0
nosy_names = ['terry.reedy', 'miss-islington']
pr_nums = ['12491', '12501']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue36396'
versions = ['Python 3.7', 'Python 3.8']
    @terryjreedy
    Copy link
    Member Author

    The fgBg param of idlelib.config.GetHighlight() is used in only one idlelib call. Two other places could use it, but instead subscript the returned dict. Remove the parameter, make the function always return a dict and not a color, and have the one fgBg call use a subscript.

    @terryjreedy terryjreedy added 3.7 (EOL) end of life 3.8 only security fixes labels Mar 22, 2019
    @terryjreedy terryjreedy self-assigned this Mar 22, 2019
    @terryjreedy terryjreedy added topic-IDLE type-feature A feature request or enhancement labels Mar 22, 2019
    @terryjreedy
    Copy link
    Member Author

    There were two uses in IDLE and a few in the tests.

    @terryjreedy
    Copy link
    Member Author

    New changeset c141957 by Terry Jan Reedy in branch 'master':
    bpo-36396: Remove fgBg param of idlelib.config.GetHighlight() (GH-12491)
    c141957

    @miss-islington
    Copy link
    Contributor

    New changeset 2d7798a by Miss Islington (bot) in branch '3.7':
    bpo-36396: Remove fgBg param of idlelib.config.GetHighlight() (GH-12491)
    2d7798a

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @terryjreedy terryjreedy

    Labels
    3.7 (EOL) end of life 3.8 only security fixes topic-IDLE type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @terryjreedy @miss-islington