Created on 2019-03-22 02:39 by terry.reedy, last changed 2019-03-22 23:17 by terry.reedy. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 12491 | merged | terry.reedy, 2019-03-22 02:47 | |
| PR 12501 | merged | miss-islington, 2019-03-22 22:24 | |
| Messages (4) | |||
|---|---|---|---|
| msg338580 - (view) | Author: Terry J. Reedy (terry.reedy) *  |
Date: 2019-03-22 02:39 | |
The fgBg param of idlelib.config.GetHighlight() is used in only one idlelib call. Two other places could use it, but instead subscript the returned dict. Remove the parameter, make the function always return a dict and not a color, and have the one fgBg call use a subscript. |
|||
| msg338585 - (view) | Author: Terry J. Reedy (terry.reedy) * |
Date: 2019-03-22 06:14 | |
There were two uses in IDLE and a few in the tests. |
|||
| msg338619 - (view) | Author: Terry J. Reedy (terry.reedy) * |
Date: 2019-03-22 22:23 | |
New changeset c1419578a18d787393c7ccee149e7c1fff17a99e by Terry Jan Reedy in branch 'master': bpo-36396: Remove fgBg param of idlelib.config.GetHighlight() (GH-12491) https://github.com/python/cpython/commit/c1419578a18d787393c7ccee149e7c1fff17a99e |
|||
| msg338620 - (view) | Author: miss-islington (miss-islington) | Date: 2019-03-22 22:43 | |
New changeset 2d7798ad12456e137b3e3bc82a9824d0d3d45af0 by Miss Islington (bot) in branch '3.7': bpo-36396: Remove fgBg param of idlelib.config.GetHighlight() (GH-12491) https://github.com/python/cpython/commit/2d7798ad12456e137b3e3bc82a9824d0d3d45af0 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2019-03-22 23:17:05 | terry.reedy | set | status: open -> closed resolution: fixed stage: patch review -> resolved |
| 2019-03-22 22:43:03 | miss-islington | set | nosy:
+ miss-islington messages: + msg338620 |
| 2019-03-22 22:24:04 | miss-islington | set | stage: commit review -> patch review pull_requests: + pull_request12450 |
| 2019-03-22 22:23:43 | terry.reedy | set | messages: + msg338619 |
| 2019-03-22 06:14:35 | terry.reedy | set | messages:
+ msg338585 stage: patch review -> commit review |
| 2019-03-22 02:47:47 | terry.reedy | set | keywords:
+ patch stage: commit review -> patch review pull_requests: + pull_request12444 |
| 2019-03-22 02:39:03 | terry.reedy | create | |