Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not ignore errors when create posix.environ #79626

Closed
serhiy-storchaka opened this issue Dec 9, 2018 · 2 comments
Closed

Do not ignore errors when create posix.environ #79626

serhiy-storchaka opened this issue Dec 9, 2018 · 2 comments
Labels
3.8 only security fixes extension-modules C modules in the Modules dir type-feature A feature request or enhancement

Comments

@serhiy-storchaka
Copy link
Member

BPO 35445
Nosy @larryhastings, @serhiy-storchaka
PRs
  • bpo-35445: Do not ignore memory errors when create posix.environ. #11049
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2018-12-10.10:19:28.431>
created_at = <Date 2018-12-09.12:34:29.663>
labels = ['extension-modules', 'type-feature', '3.8']
title = 'Do not ignore errors when create posix.environ'
updated_at = <Date 2018-12-10.10:19:28.430>
user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2018-12-10.10:19:28.430>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = True
closed_date = <Date 2018-12-10.10:19:28.431>
closer = 'serhiy.storchaka'
components = ['Extension Modules']
creation = <Date 2018-12-09.12:34:29.663>
creator = 'serhiy.storchaka'
dependencies = []
files = []
hgrepos = []
issue_num = 35445
keywords = ['patch']
message_count = 2.0
messages = ['331427', '331483']
nosy_count = 2.0
nosy_names = ['larry', 'serhiy.storchaka']
pr_nums = ['11049']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue35445'
versions = ['Python 3.8']
    @serhiy-storchaka
    Copy link
    Member Author

    Currently most errors during creating posix.environ are ignored except an error of creating an empty dict.

    The initial revision 85a5fbb contained the comment "XXX This part ignores errors". Later changes removed "XXX" from the comment and added explicit error clearing. Later the POSIX code was duplicated for Windows. It looks to me that that comment was not declared the intentional behavior, but just described existing code, and was left as a reminder for implementing error handling.

    The proposed PR implements proper error handling in this code.

    @serhiy-storchaka serhiy-storchaka added 3.8 only security fixes extension-modules C modules in the Modules dir type-feature A feature request or enhancement labels Dec 9, 2018
    @serhiy-storchaka
    Copy link
    Member Author

    New changeset 6fef0f1 by Serhiy Storchaka in branch 'master':
    bpo-35445: Do not ignore memory errors when create posix.environ. (GH-11049)
    6fef0f1

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.8 only security fixes extension-modules C modules in the Modules dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @serhiy-storchaka