classification
Title: Do not ignore errors when create posix.environ
Type: enhancement Stage: resolved
Components: Extension Modules Versions: Python 3.8
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: larry, serhiy.storchaka
Priority: normal Keywords: patch

Created on 2018-12-09 12:34 by serhiy.storchaka, last changed 2018-12-10 10:19 by serhiy.storchaka. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 11049 merged serhiy.storchaka, 2018-12-09 12:39
Messages (2)
msg331427 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2018-12-09 12:34
Currently most errors during creating posix.environ are ignored except an error of creating an empty dict.

The initial revision 85a5fbbdfea617f6cc8fae82c9e8c2b5c424436d contained the comment "XXX This part ignores errors". Later changes removed "XXX" from the comment and added explicit error clearing. Later the POSIX code was duplicated for Windows. It looks to me that that comment was not declared the intentional behavior, but just described existing code, and was left as a reminder for implementing error handling.

The proposed PR implements proper error handling in this code.
msg331483 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2018-12-10 10:10
New changeset 6fef0f1a8162e755f3b46677265b7cf052d9b83f by Serhiy Storchaka in branch 'master':
bpo-35445: Do not ignore memory errors when create posix.environ. (GH-11049)
https://github.com/python/cpython/commit/6fef0f1a8162e755f3b46677265b7cf052d9b83f
History
Date User Action Args
2018-12-10 10:19:28serhiy.storchakasetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2018-12-10 10:10:59serhiy.storchakasetmessages: + msg331483
2018-12-09 12:39:29serhiy.storchakasetkeywords: + patch
stage: patch review
pull_requests: + pull_request10285
2018-12-09 12:34:29serhiy.storchakacreate