Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC: Makefile inherits a Sphinx 1.5 bug regarding PAPER envvar #78474

Closed
jfbu mannequin opened this issue Jul 31, 2018 · 6 comments
Closed

DOC: Makefile inherits a Sphinx 1.5 bug regarding PAPER envvar #78474

jfbu mannequin opened this issue Jul 31, 2018 · 6 comments
Labels
3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes docs Documentation in the Doc dir type-bug An unexpected behavior, bug, or error

Comments

@jfbu
Copy link
Mannequin

jfbu mannequin commented Jul 31, 2018

BPO 34293
Nosy @zware, @jfbu
PRs
  • bpo-34293: fix DOC Makefile regarding PAPER envvar #8585
  • [3.8] bpo-34293: Fix PDF documentation paper size (GH-8585) #15816
  • [3.7] bpo-34293: Fix PDF documentation paper size (GH-8585) #15817
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2019-09-09.21:59:54.098>
created_at = <Date 2018-07-31.13:10:13.284>
labels = ['3.8', 'type-bug', '3.7', '3.9', 'docs']
title = 'DOC: Makefile inherits a Sphinx 1.5 bug regarding PAPER envvar'
updated_at = <Date 2019-09-09.22:11:37.191>
user = 'https://github.com/jfbu'

    bugs.python.org fields:

    activity = <Date 2019-09-09.22:11:37.191>
actor = 'zach.ware'
assignee = 'docs@python'
closed = True
closed_date = <Date 2019-09-09.21:59:54.098>
closer = 'zach.ware'
components = ['Documentation']
creation = <Date 2018-07-31.13:10:13.284>
creator = 'jfbu'
dependencies = []
files = []
hgrepos = []
issue_num = 34293
keywords = ['patch']
message_count = 6.0
messages = ['322770', '322774', '351554', '351556', '351558', '351559']
nosy_count = 3.0
nosy_names = ['docs@python', 'zach.ware', 'jfbu']
pr_nums = ['8585', '15816', '15817']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue34293'
versions = ['Python 3.7', 'Python 3.8', 'Python 3.9']
    @jfbu
    Copy link
    Mannequin Author

    jfbu mannequin commented Jul 31, 2018

    There has been a bug at Sphinx since release 1.5 sphinx-doc/sphinx#5234 about wrong handling of PAPER environment variable. The Makefile in Doc/ reproduces the error. As a result the "A4 latex" and "letter latex" sub targets of "dist" mis-behave.

    A bugfix will be released at Sphinx 1.7.7 or 1.8 but the CPython Doc/Makefile needs an update, because the bugfix can only solve problems for new projects created with sphinx-quickstart (whether or not using the "make-mode" small Makefile, or the "no-make-mode" bigger Makefile which was default up to Sphinx 1.5).

    I will send PR next.

    @jfbu jfbu mannequin assigned docspython Jul 31, 2018
    @jfbu jfbu mannequin added docs Documentation in the Doc dir type-bug An unexpected behavior, bug, or error labels Jul 31, 2018
    @jfbu
    Copy link
    Mannequin Author

    jfbu mannequin commented Jul 31, 2018

    #8585

    @zware
    Copy link
    Member

    zware commented Sep 9, 2019

    New changeset b5381f6 by Zachary Ware (Jean-François B) in branch 'master':
    bpo-34293: Fix PDF documentation paper size (GH-8585)
    b5381f6

    @zware
    Copy link
    Member

    zware commented Sep 9, 2019

    Thank you for the patch!

    @zware zware added 3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes labels Sep 9, 2019
    @zware zware closed this as completed Sep 9, 2019
    @zware
    Copy link
    Member

    zware commented Sep 9, 2019

    New changeset 99df5e8 by Zachary Ware in branch '3.8':
    [3.8] bpo-34293: Fix PDF documentation paper size (GH-8585) (GH-15816)
    99df5e8

    @zware
    Copy link
    Member

    zware commented Sep 9, 2019

    New changeset 12228ce by Zachary Ware in branch '3.7':
    [3.7] bpo-34293: Fix PDF documentation paper size (GH-8585) (GH-15817)
    12228ce

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes docs Documentation in the Doc dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @zware