classification
Title: DOC: Makefile inherits a Sphinx 1.5 bug regarding PAPER envvar
Type: behavior Stage: resolved
Components: Documentation Versions: Python 3.9, Python 3.8, Python 3.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: docs@python Nosy List: docs@python, jfbu, zach.ware
Priority: normal Keywords: patch

Created on 2018-07-31 13:10 by jfbu, last changed 2019-09-09 22:11 by zach.ware. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 8585 merged jfbu, 2018-07-31 13:32
PR 15816 merged zach.ware, 2019-09-09 21:54
PR 15817 merged zach.ware, 2019-09-09 21:57
Messages (6)
msg322770 - (view) Author: jfbu (jfbu) * Date: 2018-07-31 13:10
There has been a bug at Sphinx since release 1.5 https://github.com/sphinx-doc/sphinx/issues/5234 about wrong handling of PAPER environment variable. The Makefile in Doc/ reproduces the error. As a result the "A4 latex" and "letter latex" sub targets of "dist" mis-behave.

A bugfix will be released at Sphinx 1.7.7 or 1.8 but the CPython Doc/Makefile needs an update, because the bugfix can only solve problems for new projects created with sphinx-quickstart (whether or not using the "make-mode" small Makefile, or the "no-make-mode" bigger Makefile which was default up to Sphinx 1.5).

I will send PR next.
msg322774 - (view) Author: jfbu (jfbu) * Date: 2018-07-31 13:40
https://github.com/python/cpython/pull/8585
msg351554 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2019-09-09 21:52
New changeset b5381f669718aa19690f42f3b8bd88f03045b9d2 by Zachary Ware (Jean-François B) in branch 'master':
bpo-34293: Fix PDF documentation paper size (GH-8585)
https://github.com/python/cpython/commit/b5381f669718aa19690f42f3b8bd88f03045b9d2
msg351556 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2019-09-09 21:59
Thank you for the patch!
msg351558 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2019-09-09 22:11
New changeset 99df5e837334b62c29c979bb0806f525778a4f3e by Zachary Ware in branch '3.8':
[3.8] bpo-34293: Fix PDF documentation paper size (GH-8585) (GH-15816)
https://github.com/python/cpython/commit/99df5e837334b62c29c979bb0806f525778a4f3e
msg351559 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2019-09-09 22:11
New changeset 12228ce41de1b8fcfb3f1ba0a86d98a232815e85 by Zachary Ware in branch '3.7':
[3.7] bpo-34293: Fix PDF documentation paper size (GH-8585) (GH-15817)
https://github.com/python/cpython/commit/12228ce41de1b8fcfb3f1ba0a86d98a232815e85
History
Date User Action Args
2019-09-09 22:11:37zach.waresetmessages: + msg351559
2019-09-09 22:11:26zach.waresetmessages: + msg351558
2019-09-09 21:59:54zach.waresetstatus: open -> closed
versions: + Python 3.7, Python 3.8, Python 3.9
messages: + msg351556

resolution: fixed
stage: patch review -> resolved
2019-09-09 21:57:56zach.waresetpull_requests: + pull_request15465
2019-09-09 21:54:51zach.waresetpull_requests: + pull_request15464
2019-09-09 21:52:06zach.waresetnosy: + zach.ware
messages: + msg351554
2018-07-31 13:40:15jfbusetmessages: + msg322774
2018-07-31 13:32:34jfbusetkeywords: + patch
stage: patch review
pull_requests: + pull_request8094
2018-07-31 13:10:13jfbucreate