classification
Title: Refer to gnuwin32 diff util on development FAQ
Type: enhancement Stage: resolved
Components: Documentation Versions:
process
Status: closed Resolution: rejected
Dependencies: Superseder:
Assigned To: docs@python Nosy List: BreamoreBoy, brian.curtin, docs@python, michael.foord, techtonik
Priority: normal Keywords: easy

Created on 2010-07-25 11:58 by BreamoreBoy, last changed 2010-07-26 15:10 by brian.curtin. This issue is now closed.

Messages (9)
msg111536 - (view) Author: Mark Lawrence (BreamoreBoy) * Date: 2010-07-25 11:58
Section 6.1 How to make a patch? currently reads in part

(a Windows version is available as part of the cygwin tools).

I suggest that this is reworded to read

(Windows versions are available as part of the cygwin tools or as part of the gnuwin32 project)

I simply find it much easier to download and install these individual tools, e.g. I also have their version of grep which is vastly superior to Windows find
msg111610 - (view) Author: anatoly techtonik (techtonik) Date: 2010-07-26 13:26
There is diff.py utility that is already available from standard Python distribution.
msg111621 - (view) Author: Brian Curtin (brian.curtin) * (Python committer) Date: 2010-07-26 14:21
I don't think we should have a list of three alternatives to the single way you really should be creating diffs. If you are working on Python you should have Subversion and run "svn diff", or have Mercurual and run "hg diff".

I guess I'm -0 on this idea. I also don't even know where the dev/faq page is located in SVN to make any potential change.
msg111622 - (view) Author: Michael Foord (michael.foord) * (Python committer) Date: 2010-07-26 14:24
"svn diff" should be the one true way for creating patches, especially for windows users. This will all change when we switch to mercurial.
msg111623 - (view) Author: anatoly techtonik (techtonik) Date: 2010-07-26 14:27
The better way would be
> python -m easy_install review
> python -m review
msg111624 - (view) Author: Brian Curtin (brian.curtin) * (Python committer) Date: 2010-07-26 14:30
Until Rietveld has a defined place in our workflow, I don't think that's a good idea.

I think that will be a part of the process in the future, but we're not defining that here.
msg111629 - (view) Author: Mark Lawrence (BreamoreBoy) * Date: 2010-07-26 15:07
I believe that the switch to mercurial is months if not years away, so I'd quite happily see just a reference to svn diff.  Failing that I wouldn't loose any sleep over closing this, ok to leave it with you Brian?
msg111632 - (view) Author: anatoly techtonik (techtonik) Date: 2010-07-26 15:09
> Brian Curtin <curtin@acm.org> added the comment:
>
> Until Rietveld has a defined place in our workflow, I don't think that's a good idea.

1. AFAIK Python don't have any workflow. Do you speak about your own workflow?
2. What conditions should become True for you to think that's a good
idea? I.e. fill the blanks:
    if ... and ... and ...:
      debug("Rietveld has a defined place in out workflow")
      good_idea = True
msg111634 - (view) Author: Brian Curtin (brian.curtin) * (Python committer) Date: 2010-07-26 15:10
"svn diff" is already explained a few times in the doc, including the line above the suggested change.
History
Date User Action Args
2010-07-26 15:10:37brian.curtinsetstatus: open -> closed
resolution: rejected
messages: + msg111634

stage: resolved
2010-07-26 15:09:46techtoniksetmessages: + msg111632
2010-07-26 15:07:01BreamoreBoysetmessages: + msg111629
2010-07-26 14:30:42brian.curtinsetmessages: + msg111624
2010-07-26 14:27:38techtoniksetmessages: + msg111623
2010-07-26 14:24:38michael.foordsetnosy: + michael.foord
messages: + msg111622
2010-07-26 14:21:28brian.curtinsetnosy: + brian.curtin
messages: + msg111621
2010-07-26 13:26:39techtoniksetnosy: + techtonik
messages: + msg111610
2010-07-25 11:58:37BreamoreBoycreate