This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Title: Cruft in object.c: PyObject_GenericGetAttr
Type: Stage:
Components: Interpreter Core Versions: Python 3.2, Python 2.7
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: Yaniv.Aknin, amaury.forgeotdarc, mark.dickinson
Priority: normal Keywords:

Created on 2010-05-18 12:06 by Yaniv.Aknin, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Messages (4)
msg105967 - (view) Author: Yaniv Aknin (Yaniv.Aknin) Date: 2010-05-18 12:06
While reading the source I saw that recent py3k has this in Objects/object.c (reasonably recent trunk has it as well):

#if 0 /* XXX this is not quite _PyType_Lookup anymore */
    /* Inline _PyType_Lookup */
    { ... removed ...
    descr = _PyType_Lookup(tp, name);

This was commented out (on trunk, I assumed on py3k it was for the same reason) by amaury.forgeotdarc on revision 59943, when a patch to the real _PyType_Lookup was applied.

I think it can be safely removed.
msg105968 - (view) Author: Mark Dickinson (mark.dickinson) * (Python committer) Date: 2010-05-18 12:17
Looks like r59944 to me.

Amaury, any objections to removing this '#if 0' code?
msg105969 - (view) Author: Yaniv Aknin (Yaniv.Aknin) Date: 2010-05-18 12:22
Oops, of course I meant r59944, off by one. :)
msg106302 - (view) Author: Mark Dickinson (mark.dickinson) * (Python committer) Date: 2010-05-22 12:02
Fixed in r81470.
Date User Action Args
2022-04-11 14:57:01adminsetgithub: 52995
2010-05-22 12:02:54mark.dickinsonsetstatus: open -> closed
resolution: fixed
messages: + msg106302
2010-05-18 12:22:17Yaniv.Akninsetmessages: + msg105969
2010-05-18 12:17:46mark.dickinsonsetnosy: + amaury.forgeotdarc
messages: + msg105968
2010-05-18 12:10:28mark.dickinsonsetnosy: + mark.dickinson
2010-05-18 12:06:27Yaniv.Aknincreate