This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Title: suspicious comment in
Type: Stage:
Components: Library (Lib), Windows Versions: Python 2.6
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: BreamoreBoy, janssen, loewis, markm
Priority: low Keywords:

Created on 2010-04-28 01:31 by janssen, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Messages (4)
msg104393 - (view) Author: Bill Janssen (janssen) * (Python committer) Date: 2010-04-28 01:31
Take a look at the first line of make_id().  What does that comment mean?  Is the wrong line commented out?

def make_id(str, add_num=True):
    #str = str.replace(".", "_") # colons are allowed
msg116575 - (view) Author: Mark Lawrence (BreamoreBoy) * Date: 2010-09-16 16:59
The line in question has been like that since r42847 i.e. when the file came into existence.
msg132226 - (view) Author: Mark Mc Mahon (markm) * Date: 2011-03-26 10:24
"""The Identifier data type is a text string. Identifiers may contain the
ASCII characters A-Z (a-z), digits, underscores (_), or periods (.). However, every identifier must begin with either a letter or an underscore."""

So the spec would say that colons are NOT allowed. Editing some entries in the File table of an MSI (using Orca from the MSI SDK) and running the validation confirms that.

All the following were flagged as errors during validation:
'KDiff3EXE;"ASDF@#$', 'chmFile-', 'pdfFile(', 'hgbook]', 'TortoisePlinkEXE]', 'Hg.Cämd', 'merg:epatterns.rc'

I think that this issue should be fixed when issue2694 is fixed. (I would like to put together some tests and patch for that :)
msg132547 - (view) Author: Mark Mc Mahon (markm) * Date: 2011-03-29 22:15
This issue has been fixed when issue11696 was fixed.
Date User Action Args
2022-04-11 14:57:00adminsetgithub: 52800
2011-03-30 05:34:01loewissetstatus: open -> closed
resolution: fixed
2011-03-29 22:15:59markmsetmessages: + msg132547
2011-03-26 10:24:12markmsetnosy: + markm
messages: + msg132226
2010-09-16 16:59:01BreamoreBoysetnosy: + BreamoreBoy
messages: + msg116575
2010-04-28 01:31:30janssencreate