This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Title: test_largefile cleanup patch
Type: Stage:
Components: Tests Versions: Python 2.4
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: jlt63 Nosy List: jlt63
Priority: normal Keywords: patch

Created on 2003-08-11 11:55 by jlt63, last changed 2022-04-10 16:10 by admin. This issue is now closed.

File name Uploaded Description Edit jlt63, 2003-08-11 11:55
Messages (2)
msg44433 - (view) Author: Jason Tishler (jlt63) * (Python triager) Date: 2003-08-11 11:55
test_largefile can leave its temp file open if one
of many tests fail. On platforms (e.g., Cygwin)
that are "particular" about open files, this will
cause other regression tests that use the same
temp file to fail:

$ ./python.exe -E -tt Lib/test/ -l 
test_largefile test_mmap test_mutants 
test test_largefile failed -- got -1794967295L, but 
expected 2500000001L
test test_mmap crashed -- exceptions.IOError: [Errno 
13] Permission denied: '@test'
test test_mutants crashed -- exceptions.IOError: [Errno 
13] Permission denied: '@test'

The attached patch solves this problem by adding
missing "try/finally" blocks.  Note that the
"large" size of this patch is due to many white
space changes -- otherwise, the patch is small.

I tested this patch under Red Hat Linux 8.0 too.

Is someone willing to eyeball this one before I
check it in? Thanks.
msg44434 - (view) Author: Jason Tishler (jlt63) * (Python triager) Date: 2003-08-26 12:02
Logged In: YES 

I guess that the eyeballs didn't find anything or weren't
looking... :,)

Committed on HEAD as Lib/test/ 1.17 and
release23-maint as Lib/test/
Date User Action Args
2022-04-10 16:10:34adminsetgithub: 39044
2003-08-11 11:55:44jlt63create