This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Title: [PATCH] Drop "Computer" from "Apple Computer" in plistlib
Type: behavior Stage: resolved
Components: Library (Lib) Versions: Python 3.2, Python 2.7
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: ronaldoussoren Nosy List: ezio.melotti, ronaldoussoren, vstinner, wangchun, zvezdan
Priority: low Keywords: patch

Created on 2010-02-04 09:02 by wangchun, last changed 2022-04-11 14:56 by admin. This issue is now closed.

File name Uploaded Description Edit
plistlib.diff wangchun, 2010-02-04 09:02
Messages (8)
msg98815 - (view) Author: Wang Chun (wangchun) Date: 2010-02-04 09:02
Apple's official utilities had been dropped the word "Computer". We should follow them.

imac:~$ cat
__import__('plistlib').writePlist({}, 'test.plist')
imac:~$ python
imac:~$ cat
__import__('plistlib').writePlist({}, 'test.plist')
imac:~$ python
imac:~$ cat test.plist
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple Computer//DTD PLIST 1.0//EN" "">
<plist version="1.0">
imac:~$ plutil -convert xml1 test.plist
imac:~$ cat test.plist
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "">
<plist version="1.0">
msg98893 - (view) Author: Ezio Melotti (ezio.melotti) * (Python committer) Date: 2010-02-05 18:28
I did a quick search and couldn't find any reference about this change, the examples in the apple doc still use 'Apple Computer'.
Do you have any reference that says that the correct doctype (now) uses only 'Apple'?
msg98905 - (view) Author: Zvezdan Petkovic (zvezdan) * Date: 2010-02-05 20:30
How about this example from Mac OS X Reference Library "Property List Programming Guide":

Perhaps the fact that Apple officially changed the name from "Apple Computer" to "Apple" back in 2007 also helps:

This one had a short URL, you can search Google for "apple computer changes name" for more (Forbes, Information Week, etc.)

Do you have a reference where Apple docs written after 2007 use "Apple Computer"?
msg98907 - (view) Author: Zvezdan Petkovic (zvezdan) * Date: 2010-02-05 20:44
Also, on a Mac computer:

- start Xcode 3.2.1 and select Help->Developer Documentation
- type in the search box in the top right corner "property list"
- the second hit is "Property List Programming Guide"; click on it
- the second page gives the same example as the URL I put in msg98905
- it uses DOCTYPE with /Apple/ only
msg98916 - (view) Author: Wang Chun (wangchun) Date: 2010-02-05 22:34
plutil is a command shipped with every Mac. See the example in my original post.
msg103759 - (view) Author: Ronald Oussoren (ronaldoussoren) * (Python committer) Date: 2010-04-20 21:01
I agree that the DTD should be changed.

Fixed in r80279 (trunk) and r80280 (3.2). 

I won't backport to 2.6 and 3.1 because this is a mostly cosmetic issue and I do not want to risk breaking existing scripts.
msg103783 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2010-04-20 22:20
r80279 and r80280 caused many buildbot to fail:

 i386 Ubuntu 3.x
 AMD64 Ubuntu trunk 
 AMD64 Ubuntu wide trunk 
 x86 Ubuntu trunk
 x86 XP-4 trunk 
 x86 XP-5 trunk 

FAIL: test_appleformatting (test.test_plistlib.TestPlistlib)
Traceback (most recent call last):
  File "/scratch/pybot-buildarea/3.x.klose-ubuntu-i386/build/Lib/test/", line 142, in test_appleformatting
    "generated data was not identical to Apple's output")
AssertionError: generated data was not identical to Apple's output

msg104498 - (view) Author: Ronald Oussoren (ronaldoussoren) * (Python committer) Date: 2010-04-29 13:00
test failures have been fixed a while back.
Date User Action Args
2022-04-11 14:56:57adminsetgithub: 52100
2010-04-29 13:00:41ronaldoussorensetstatus: open -> closed
resolution: fixed
messages: + msg104498
2010-04-20 22:20:32vstinnersetstatus: closed -> open

nosy: + vstinner
messages: + msg103783

resolution: fixed -> (no value)
2010-04-20 21:01:52ronaldoussorensetstatus: open -> closed
versions: + Python 3.2
messages: + msg103759

resolution: fixed
stage: patch review -> resolved
2010-02-09 09:05:10ronaldoussorensetassignee: ronaldoussoren
2010-02-05 22:34:55wangchunsetmessages: + msg98916
2010-02-05 21:24:55ezio.melottisetnosy: + ronaldoussoren
2010-02-05 20:44:31zvezdansetmessages: + msg98907
2010-02-05 20:30:45zvezdansetnosy: + zvezdan
messages: + msg98905
2010-02-05 18:28:52ezio.melottisetpriority: low

nosy: + ezio.melotti
messages: + msg98893

stage: patch review
2010-02-04 09:02:08wangchuncreate