This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: iconv codec-NG and Korean Codecs
Type: Stage:
Components: Library (Lib) Versions: Python 2.3
process
Status: closed Resolution: rejected
Dependencies: Superseder:
Assigned To: loewis Nosy List: hyeshik.chang, loewis
Priority: normal Keywords: patch

Created on 2003-03-27 19:31 by hyeshik.chang, last changed 2022-04-10 16:07 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
python-mbc.diff.gz hyeshik.chang, 2003-03-27 19:32 patch (rev.1)
Messages (2)
msg43194 - (view) Author: Hyeshik Chang (hyeshik.chang) * (Python committer) Date: 2003-03-27 19:31
This patch includes update for iconv_codec, new 
sources for korean codecs and MultibyteCodec 
supplemental library.
I splitted out common parts of codecs for usual 
multibyte encodings into multibytecodec.c and this 
iconv codec and the korean codecs are using it.
The korean codecs is only 58K in stripped i386 ELF and 
62K in stripped i386 PECOFF binary and I think it's 
small enough to be incorporated into python.

Files:

Lib/encodings/aliases.py
   adds aliases for korean encodings and remove 
comments that isn't true now.

Lib/encodings/cp949.py
Lib/encodings/euc_kr.py
   codecs for korean encodings

Lib/encodings/iconv_codec.py
   updated for new _iconv_codec implementation

Lib/test/test_ko_codecs.py
   unit test for cp949, euc_kr codec

Lib/test/test_ko_codecs_mapping.py
   unit test to test cp949 mapping

Lib/test/test_iconv_codec_euc_kr.py
   another iconv_codec test unit. because non-unicode 
multibyte encoding is required to test both of 
iconv_codec and multibytecodec.

Lib/test/test_multibytecodec_support.py
   common part for above test units

Modules/_iconv_codec.c
   new implementation of _iconv_codec.
   this resolves numerous problems that previous 
implementation had. and iconv_codec has sane 
StreamReader now! :)

Modules/_ko_codec.c
Modules/_ko_codec.h
   korean codecs module

Modules/multibytecodec.c
Modules/multibytecodec.h
   common multibyte codec supplement. I think that this 
can be used for any usual multibyte encodings.
   I'll submit Chinese Codecs in few days using this.

Tools/unicode/genmap_ko_codecs.py
   code generator for _ko_codecs.h
msg43195 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2003-03-29 15:00
Logged In: YES 
user_id=21627

Please submit an individual patch for each single bug fix or
new feature; it appears that this patch deals with
completely unrelated things. Therefore. I'm rejecting this
patch, encouraging you to submit new separate patches.

I have a few specific comments you may want to consider:

- What is the rationale for adding an alias processing to
the iconv codecs?

- It is unclear how you expect reuse of the
multibytecodec.c. Currently, this is incorporated into
_ko_codecs. How would this cooperate with other usages of
multibytecodecs? In particular, why is that needed in
iconv_codec?

- "complete reimplementation" is insufficient reason to
accept a change. What specific problems does the old iconv
codec have, and how specifically have they been corrected?
History
Date User Action Args
2022-04-10 16:07:55adminsetgithub: 38224
2003-03-27 19:31:49hyeshik.changcreate