Title: test_time fails on VC6
Type: Stage:
Components: Extension Modules Versions: Python 3.1
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: loewis, ocean-city
Priority: normal Keywords: patch

Created on 2009-06-03 02:19 by ocean-city, last changed 2009-06-03 05:20 by ocean-city. This issue is now closed.

File name Uploaded Description Edit
patch_for_under_71.patch ocean-city, 2009-06-03 02:19
Messages (3)
msg88786 - (view) Author: Hirokazu Yamamoto (ocean-city) * (Python committer) Date: 2009-06-03 02:19
test_time fails on VC6 with following message.

FAIL: test_strptime (__main__.TimeTestCase)
Traceback (most recent call last):
  File "", line 246, in <module>
  File "", line 243, in test_main
    support.run_unittest(TimeTestCase, TestLocale)
  File "e:\python-dev\py3k\lib\test\", line 879, in run_unittest
  File "e:\python-dev\py3k\lib\test\", line 854, in _run_suite
    result =
  File "e:\python-dev\py3k\lib\", line 1490, in run
  File "e:\python-dev\py3k\lib\", line 1451, in printErrors
    self.printErrorList('FAIL', self.failures)
  File "e:\python-dev\py3k\lib\", line 1458, in printErrorList"%s" % err)
  File "e:\python-dev\py3k\lib\", line 1367, in writeln
UnicodeEncodeError: 'cp932' codec can't encode character '\x93' in
position 453:
 illegal multibyte sequence

Here is quotation from

> Note   Before this version of Visual C++, the documentation described
> the format parameter of wcsftime as having the datatype const wchar_t
> *, but the actual implementation of the format datatype was const
> char *. In this version, the implementation of the format datatype
> has been updated to reflect the previous and current documentation, 
> that is: const wchar_t *.

Can I apply attached patch? Thank you.
msg88793 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2009-06-03 04:30
> Can I apply attached patch? Thank you.

Looks fine to me, go ahead.
msg88794 - (view) Author: Hirokazu Yamamoto (ocean-city) * (Python committer) Date: 2009-06-03 05:20
Thanks, committed in r73162.
Date User Action Args
2009-06-03 05:20:36ocean-citysetstatus: open -> closed
resolution: fixed
messages: + msg88794
2009-06-03 04:30:43loewissetnosy: + loewis
messages: + msg88793
2009-06-03 02:19:27ocean-citycreate