classification
Title: test_time fails on VC6
Type: Stage:
Components: Extension Modules Versions: Python 3.1
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: loewis, ocean-city
Priority: normal Keywords: patch

Created on 2009-06-03 02:19 by ocean-city, last changed 2009-06-03 05:20 by ocean-city. This issue is now closed.

Files
File name Uploaded Description Edit
patch_for_under_71.patch ocean-city, 2009-06-03 02:19
Messages (3)
msg88786 - (view) Author: Hirokazu Yamamoto (ocean-city) * (Python committer) Date: 2009-06-03 02:19
test_time fails on VC6 with following message.

======================================================================
FAIL: test_strptime (__main__.TimeTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test_time.py", line 246, in <module>
    test_main()
  File "test_time.py", line 243, in test_main
    support.run_unittest(TimeTestCase, TestLocale)
  File "e:\python-dev\py3k\lib\test\support.py", line 879, in run_unittest
    _run_suite(suite)
  File "e:\python-dev\py3k\lib\test\support.py", line 854, in _run_suite
    result = runner.run(suite)
  File "e:\python-dev\py3k\lib\unittest.py", line 1490, in run
    result.printErrors()
  File "e:\python-dev\py3k\lib\unittest.py", line 1451, in printErrors
    self.printErrorList('FAIL', self.failures)
  File "e:\python-dev\py3k\lib\unittest.py", line 1458, in printErrorList
    self.stream.writeln("%s" % err)
  File "e:\python-dev\py3k\lib\unittest.py", line 1367, in writeln
    self.write(arg)
UnicodeEncodeError: 'cp932' codec can't encode character '\x93' in
position 453:
 illegal multibyte sequence


Here is quotation from 
http://msdn.microsoft.com/en-us/library/fe06s4ak%28VS.71%29.aspx

> Note   Before this version of Visual C++, the documentation described
> the format parameter of wcsftime as having the datatype const wchar_t
> *, but the actual implementation of the format datatype was const
> char *. In this version, the implementation of the format datatype
> has been updated to reflect the previous and current documentation, 
> that is: const wchar_t *.


Can I apply attached patch? Thank you.
msg88793 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2009-06-03 04:30
> Can I apply attached patch? Thank you.

Looks fine to me, go ahead.
msg88794 - (view) Author: Hirokazu Yamamoto (ocean-city) * (Python committer) Date: 2009-06-03 05:20
Thanks, committed in r73162.
History
Date User Action Args
2009-06-03 05:20:36ocean-citysetstatus: open -> closed
resolution: fixed
messages: + msg88794
2009-06-03 04:30:43loewissetnosy: + loewis
messages: + msg88793
2009-06-03 02:19:27ocean-citycreate