classification
Title: _elementtree import can fail silently
Type: Stage:
Components: XML Versions:
process
Status: closed Resolution: duplicate
Dependencies: Superseder:
Assigned To: Nosy List: naufraghi
Priority: normal Keywords:

Created on 2009-04-17 09:35 by naufraghi, last changed 2009-04-18 00:12 by benjamin.peterson. This issue is now closed.

Messages (2)
msg86062 - (view) Author: Matteo Bertini (naufraghi) * Date: 2009-04-17 09:35
(the patch is old, I forwarded it to Fredrik but I forgot to open the bug)

Playing with PyInstaller I have found that the final part of _elementtree.c:

Index: Modules/_elementtree.c
===================================================================
--- Modules/_elementtree.c      (revisione 59540)
+++ Modules/_elementtree.c      (copia locale)
@@ -2780,7 +2780,10 @@

        );

-    PyRun_String(bootstrap, Py_file_input, g, NULL);
+    if (PyRun_String(bootstrap, Py_file_input, g, NULL) == NULL) {
+        m = PyErr_Occurred();
+        return;
+    }

     elementpath_obj = PyDict_GetItemString(g, "ElementPath");

executes a bit of python code without checking the return value.
That can lead to weird things playing with import hooks,
for example an assert like this can fail:

Index: Lib/test/test_elemettree.py
===================================================================
--- Lib/test/test_elemettree.py (revisione 0)
+++ Lib/test/test_elemettree.py (revisione 0)
@@ -0,0 +1,21 @@
+#! /usr/bin/env python
+
+def importHook(*args, **kwargs):
+    if 'xml.etree' in args:
+        raise ImportError
+    else:
+        return __real__import__(*args, **kwargs)
+
+import os
+import __builtin__
+__real__import__ = __builtin__.__import__
+__builtin__.__import__ = importHook
+
+try:
+    import xml.etree.cElementTree as cET
+except ImportError:
+    pass
+else:
+    out = os.popen("python -c 'import xml.etree.cElementTree as cET;
print dir(cET)'").read().strip()
+    assert str(dir(cET)) == out, (str(dir(cET)), out)
+

Quite a novice with python internals, so comments are welcome.
Matteo Bertini
msg86064 - (view) Author: Matteo Bertini (naufraghi) * Date: 2009-04-17 09:40
Ups, I duplicated myself... issue3475
History
Date User Action Args
2009-04-18 00:12:16benjamin.petersonsetresolution: duplicate
2009-04-17 09:40:09naufraghisetstatus: open -> closed

messages: + msg86064
2009-04-17 09:35:08naufraghicreate