classification
Title: pickle test for protocol 3 (HIGHEST_PROTOCOL in py3k)
Type: Stage: resolved
Components: Tests Versions: Python 3.0, Python 3.1
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: benjamin.peterson, ocean-city
Priority: normal Keywords: easy, patch

Created on 2008-12-24 18:24 by ocean-city, last changed 2008-12-27 04:44 by ocean-city. This issue is now closed.

Files
File name Uploaded Description Edit
py3k_use_HIGHEST_PROTOCOL.patch ocean-city, 2008-12-24 18:24
trunk_use_HIGHEST_PROTOCOL.patch ocean-city, 2008-12-27 03:31
Messages (5)
msg78268 - (view) Author: Hirokazu Yamamoto (ocean-city) * (Python committer) Date: 2008-12-24 18:24
This patch enables tests for pickle.HIGHEST_PROTOCOL. (3)
I confirmed test passed.
msg78335 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2008-12-27 03:19
Looks fine to me. This happens in the trunk already, right?
msg78336 - (view) Author: Hirokazu Yamamoto (ocean-city) * (Python committer) Date: 2008-12-27 03:31
Not yet. This patch is for trunk. But HIGHEST_PROTOCOL is 2 in trunk, 
so no difference in behavior. (Just useful for consistency)
msg78337 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2008-12-27 03:47
Go ahead.
msg78340 - (view) Author: Hirokazu Yamamoto (ocean-city) * (Python committer) Date: 2008-12-27 04:44
Done. Fixed in r67930(trunk), r67931(py3k)
History
Date User Action Args
2008-12-27 04:44:14ocean-citysetstage: patch review -> resolved
2008-12-27 04:44:00ocean-citysetstatus: open -> closed
resolution: fixed
messages: + msg78340
2008-12-27 03:47:07benjamin.petersonsetmessages: + msg78337
2008-12-27 03:31:20ocean-citysetfiles: + trunk_use_HIGHEST_PROTOCOL.patch
messages: + msg78336
2008-12-27 03:19:37benjamin.petersonsetnosy: + benjamin.peterson
messages: + msg78335
2008-12-24 18:24:45ocean-citycreate