➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Simplify except* implementation and move helpers to exceptions.c
Type: Stage: resolved
Components: Interpreter Core Versions: Python 3.11
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: iritkatriel Nosy List: iritkatriel
Priority: normal Keywords: patch

Created on 2022-01-01 13:59 by iritkatriel, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 30289 merged iritkatriel, 2022-01-01 14:04
Messages (2)
msg409458 - (view) Author: Irit Katriel (iritkatriel) * (Python committer) Date: 2022-01-01 13:59 
Following issue45711, the implementation of except* can be simplified - we do not need to use POP_EXCEPT_AND_RERAISE to reraise the exception calculated by PREP_RERAISE_STAR, we can instead 

1. Make PREP_RERAISE_STAR not push a dummy lasti to the stack.
2. USE ROT_TWO + POP_EXCEPT + RERAISE.


While I'm there, I will move the PREP_RERAISE_STAR helper functions (do_reraise_star etc) to exceptions.c.
msg409541 - (view) Author: Irit Katriel (iritkatriel) * (Python committer) Date: 2022-01-02 23:23 
Fixed in https://github.com/python/cpython/pull/30289.
History
Date User Action Args
2022-04-11 14:59:54adminsetgithub: 90379
2022-01-02 23:23:49iritkatrielsetstatus: open -> closed
resolution: fixed
messages: + msg409541

stage: patch review -> resolved
2022-01-01 14:04:25iritkatrielsetkeywords: + patch
stage: patch review
pull_requests: + pull_request28540
2022-01-01 13:59:07iritkatrielcreate