➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2021-11-22 10:29 by adamchainz, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 29698 | open | adamchainz, 2021-11-22 10:33 | |
| Messages (5) | |||
|---|---|---|---|
| msg406757 - (view) | Author: Adam Johnson (adamchainz) * | Date: 2021-11-22 10:29 | |
I often browse the unittest code in order to write extensions. It still uses some Python 2-isms like classes inheriting from object, it would be nice to clean that up. |
|||
| msg406770 - (view) | Author: Eric V. Smith (eric.smith) *  |
Date: 2021-11-22 12:51 | |
As a general rule, we don't accept large patches with changes like this. The chance for breakage somewhere in the 27 files is too high. I could see maybe dropping inheriting from object, since that's relatively safe. |
|||
| msg406799 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2021-11-22 20:00 | |
Concur with Eric. |
|||
| msg409137 - (view) | Author: Adam Johnson (adamchainz) * | Date: 2021-12-24 09:48 | |
Okay, I updated the PR to only remove inheritance from object. Should I reopen the ticket? (Not sure of the etiquette.) Perhaps I could later submit a second patch for use of `super()`, and so on? |
|||
| msg409139 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2021-12-24 09:59 | |
Not worth the hassle. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:52 | admin | set | github: 90023 |
| 2021-12-24 09:59:16 | serhiy.storchaka | set | messages: + msg409139 |
| 2021-12-24 09:48:33 | adamchainz | set | messages: + msg409137 |
| 2021-11-22 20:00:45 | serhiy.storchaka | set | status: open -> closed nosy: + serhiy.storchaka messages: + msg406799 resolution: rejected stage: patch review -> resolved |
| 2021-11-22 12:51:09 | eric.smith | set | nosy:
+ eric.smith messages: + msg406770 |
| 2021-11-22 10:33:16 | adamchainz | set | keywords:
+ patch stage: patch review pull_requests: + pull_request27934 |
| 2021-11-22 10:29:50 | adamchainz | create | |