This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: [doc] "history and license" link has wrong target
Type: behavior Stage: resolved
Components: Documentation Versions: Python 3.11, Python 3.10, Python 3.9
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: docs@python Nosy List: docs@python, eric.araujo, mdk, miss-islington, programmerjake
Priority: normal Keywords: patch

Created on 2021-11-05 16:06 by programmerjake, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 30527 merged mdk, 2022-01-11 10:21
PR 30540 merged miss-islington, 2022-01-11 20:12
PR 30541 merged miss-islington, 2022-01-11 20:12
Messages (8)
msg405807 - (view) Author: Jacob Lifshay (programmerjake) Date: 2021-11-05 16:06
https://docs.python.org/3.10/library/csv.html
at the bottom the "history and license" link just links back to csv.html, rather than the correct target.
msg405818 - (view) Author: Éric Araujo (eric.araujo) * (Python committer) Date: 2021-11-05 18:46
It happens on all pages for all versions, because the link is empty.
3.8 doesn’t have that line so doesn’t show the bug.  I am trying to find where that is defined.  Strangely, I don’t find results looking for `please donate` which is the line below…
msg405820 - (view) Author: Éric Araujo (eric.araujo) * (Python committer) Date: 2021-11-05 19:02
Tracked to https://github.com/python/python-docs-theme/issues/89

AlexWaygood: can I ask why add pseudo-tags to the title field when we do have structured data (components set to doc) on this tracker?  Is it a new practice?
msg405822 - (view) Author: Alex Waygood (AlexWaygood) * (Python triager) Date: 2021-11-05 19:14
@Éric: I personally found it difficult to immediately understand what the issue was about when reading only the title on the BPO homepage, and thought the change in title would help clarify, having seen other documentation issues marked similarly on the tracker.
msg410284 - (view) Author: Julien Palard (mdk) * (Python committer) Date: 2022-01-11 10:07
This should be fixed in python-docs-theme==2022.1.

I'll close the issue when I actually see the fix applied on docs.python.org.
msg410390 - (view) Author: Julien Palard (mdk) * (Python committer) Date: 2022-01-12 10:19
I checked on docs.python.org and it's fixed.
msg410411 - (view) Author: Éric Araujo (eric.araujo) * (Python committer) Date: 2022-01-12 16:31
dev docs direct to `/license.html` which redirects to `/3/license.html`

3.9 docs have the same; wouldn’t it be better to have `/3.9/license.html`?
msg410494 - (view) Author: Julien Palard (mdk) * (Python committer) Date: 2022-01-13 15:42
> dev docs direct to `/license.html` which redirects to `/3/license.html`

All docs are redirecting to `/license.html`, this allow it to work also out of docs.python.org.

> 3.9 docs have the same; wouldn’t it be better to have `/3.9/license.html`?

It's maybe a slight better yes (the page should be the same so I don't know if it make real difference), but doing so means a bit of complexity, which I don't think is worth it.

I tried to keep it simple for this fix (the previous state was "links to the current page" which was worse).
History
Date User Action Args
2022-04-11 14:59:52adminsetgithub: 89892
2022-01-13 15:42:25mdksetmessages: + msg410494
2022-01-12 16:31:56eric.araujosetmessages: + msg410411
2022-01-12 10:19:18mdksetstatus: open -> closed
resolution: fixed
messages: + msg410390

stage: patch review -> resolved
2022-01-11 20:12:25miss-islingtonsetpull_requests: + pull_request28745
2022-01-11 20:12:08miss-islingtonsetnosy: + miss-islington
pull_requests: + pull_request28744
2022-01-11 10:21:46mdksetkeywords: + patch
stage: patch review
pull_requests: + pull_request28728
2022-01-11 10:07:48mdksetnosy: + mdk
messages: + msg410284
2021-12-12 19:44:27AlexWaygoodsetnosy: - AlexWaygood
2021-11-05 19:14:33AlexWaygoodsetmessages: + msg405822
2021-11-05 19:02:56eric.araujosetnosy: + AlexWaygood
messages: + msg405820
2021-11-05 18:48:56AlexWaygoodsettitle: "history and license" link has wrong target -> [doc] "history and license" link has wrong target
2021-11-05 18:46:59eric.araujosetversions: + Python 3.9, Python 3.11
nosy: + eric.araujo

messages: + msg405818

type: behavior
2021-11-05 16:06:13programmerjakecreate