Issue 45648: Better tp_version_tag overflow checks in specializer

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

This issue has been migrated to GitHub: https://github.com/python/cpython/issues/89811

classification

Title:	Better tp_version_tag overflow checks in specializer
Type:		Stage:	patch review
Components:		Versions:	Python 3.11

process

Status:	open	Resolution:
Dependencies:		Superseder:
Assigned To:		Nosy List:	Mark.Shannon, kj
Priority:	normal	Keywords:	patch

Created on 2021-10-28 14:53 by kj, last changed 2022-04-11 14:59 by admin.

Pull Requests
URL	Status	Linked	Edit
PR 29272	closed	kj, 2021-10-28 14:53

Messages (1)
msg405190 - (view)	Author: Ken Jin (kj) *	Date: 2021-10-28 14:53
Unless I'm mistaken, the current code in Python/specialize.c doesn't check for valid tp_version_tag, so version tag could overflow and it wouldn't know any better. Ideally, we should add more robust tests for when tp_version_tag overflows, but that's a project for another day.

msg405190 - (view)

Author: Ken Jin (kj) * (Python committer)

Date: 2021-10-28 14:53

Unless I'm mistaken, the current code in Python/specialize.c doesn't check for valid tp_version_tag, so version tag could overflow and it wouldn't know any better.

Ideally, we should add more robust tests for when tp_version_tag overflows, but that's a project for another day.

History
Date	User	Action	Args
2022-04-11 14:59:51	admin	set	github: 89811
2021-10-28 14:53:42	kj	set	keywords: + patch stage: patch review pull_requests: + pull_request27536
2021-10-28 14:53:27	kj	create