Title: Remove hostflags from PySSLContext
Type: enhancement Stage: patch review
Components: SSL Versions: Python 3.11, Python 3.10
Status: open Resolution:
Dependencies: Superseder:
Assigned To: christian.heimes Nosy List: christian.heimes, komugi, ramikg
Priority: normal Keywords:

Created on 2021-10-07 09:36 by ramikg, last changed 2021-10-09 22:35 by ramikg.

Pull Requests
URL Status Linked Edit
PR 28602 open ramikg, 2021-10-07 09:36
Messages (6)
msg403368 - (view) Author: (ramikg) * Date: 2021-10-07 09:36
The PySSLContext struct mentions that "OpenSSL has no API to get hostflags from X509_VERIFY_PARAM* struct. We have to maintain our own copy".
Since OpenSSL 1.1.0i added the function X509_VERIFY_PARAM_get_hostflags, this statement is no longer true.
Because Python 3.10 requires OpenSSL 1.1.1 (PEP 644), we no longer have to maintain a copy of the host flags.

The related PR removes the hostflags member from the PySSLContext struct.
msg403514 - (view) Author: komugi (komugi) Date: 2021-10-09 02:51
Hi, I would like to work on it. I'll send the PR tomorrow.
msg403519 - (view) Author: (ramikg) * Date: 2021-10-09 06:49
In addition to
What would the PR include?
msg403524 - (view) Author: komugi (komugi) Date: 2021-10-09 09:06
You've already done it, my bad. It was a waste of time.
msg403527 - (view) Author: Christian Heimes (christian.heimes) * (Python committer) Date: 2021-10-09 09:26
I have limited time to review code at the moment. It might take a while until I can get back to you.
msg403557 - (view) Author: (ramikg) * Date: 2021-10-09 22:35
@komugi The same code written independently by multiple people is probably the most effective and least cost-efficient form of code review.

@christian.heimes Of course, there is no hurry.
Date User Action Args
2021-10-09 22:35:38ramikgsetmessages: + msg403557
2021-10-09 09:26:25christian.heimessetmessages: + msg403527
stage: patch review
2021-10-09 09:06:24komugisetmessages: + msg403524
2021-10-09 06:49:16ramikgsetmessages: + msg403519
2021-10-09 02:51:05komugisetnosy: + komugi
messages: + msg403514
2021-10-07 09:36:55ramikgcreate