➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2021-10-07 09:36 by ramikg, last changed 2022-04-11 14:59 by admin.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 28602 | open | ramikg, 2021-10-07 09:36 | |
| Messages (6) | |||
|---|---|---|---|
| msg403368 - (view) | Author: (ramikg) * | Date: 2021-10-07 09:36 | |
The PySSLContext struct mentions that "OpenSSL has no API to get hostflags from X509_VERIFY_PARAM* struct. We have to maintain our own copy". Since OpenSSL 1.1.0i added the function X509_VERIFY_PARAM_get_hostflags, this statement is no longer true. Because Python 3.10 requires OpenSSL 1.1.1 (PEP 644), we no longer have to maintain a copy of the host flags. The related PR removes the hostflags member from the PySSLContext struct. |
|||
| msg403514 - (view) | Author: komugi (komugi) | Date: 2021-10-09 02:51 | |
Hi, I would like to work on it. I'll send the PR tomorrow. |
|||
| msg403519 - (view) | Author: (ramikg) * | Date: 2021-10-09 06:49 | |
In addition to https://github.com/python/cpython/pull/28602? What would the PR include? |
|||
| msg403524 - (view) | Author: komugi (komugi) | Date: 2021-10-09 09:06 | |
You've already done it, my bad. It was a waste of time. |
|||
| msg403527 - (view) | Author: Christian Heimes (christian.heimes) *  |
Date: 2021-10-09 09:26 | |
I have limited time to review code at the moment. It might take a while until I can get back to you. |
|||
| msg403557 - (view) | Author: (ramikg) * | Date: 2021-10-09 22:35 | |
@komugi The same code written independently by multiple people is probably the most effective and least cost-efficient form of code review. @christian.heimes Of course, there is no hurry. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:50 | admin | set | github: 89562 |
| 2021-10-09 22:35:38 | ramikg | set | messages: + msg403557 |
| 2021-10-09 09:26:25 | christian.heimes | set | messages:
+ msg403527 stage: patch review |
| 2021-10-09 09:06:24 | komugi | set | messages: + msg403524 |
| 2021-10-09 06:49:16 | ramikg | set | messages: + msg403519 |
| 2021-10-09 02:51:05 | komugi | set | nosy:
+ komugi messages: + msg403514 |
| 2021-10-07 09:36:55 | ramikg | create | |