This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Compiler warnings in longobject.c
Type: Stage:
Components: Interpreter Core Versions: Python 3.0, Python 3.1
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: mark.dickinson Nosy List: mark.dickinson, rhettinger
Priority: normal Keywords: patch

Created on 2008-12-02 21:40 by rhettinger, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
issue4497.patch mark.dickinson, 2008-12-03 21:58
Messages (6)
msg76789 - (view) Author: Raymond Hettinger (rhettinger) * (Python committer) Date: 2008-12-02 21:40
longobject.c
..\..\Objects\longobject.c(201) : warning C4244: '=' : conversion from
'long' to 'digit', possible loss of data
..\..\Objects\longobject.c(212) : warning C4244: '=' : conversion from
'long' to 'digit', possible loss of data
..\..\Objects\longobject.c(1063) : warning C4244: 'function' :
conversion from '__int64' to 'int', possible loss of data
..\..\Objects\longobject.c(1106) : warning C4244: 'function' :
conversion from 'unsigned __int64' to 'long', possible loss of data
msg76818 - (view) Author: Mark Dickinson (mark.dickinson) * (Python committer) Date: 2008-12-03 09:47
This is on Windows, right?  I don't know of any other platforms where 
__int64 is defined.

At a first glance, it looks as though the code's correct, so we probably 
just need to add some casts to silence the compiler.  I'll add them to the 
patch in issue 4393 and check it in sometime soon after 3.0 is released.
msg76847 - (view) Author: Mark Dickinson (mark.dickinson) * (Python committer) Date: 2008-12-03 21:58
Raymond, could you please try the attached patch to see if it silences the 
compiler?
msg76850 - (view) Author: Raymond Hettinger (rhettinger) * (Python committer) Date: 2008-12-03 23:02
Yes, the compiler is happy now.
msg77041 - (view) Author: Mark Dickinson (mark.dickinson) * (Python committer) Date: 2008-12-05 17:27
Fixed in r67588 (py3k), r65789 (release30-maint).
None of the fixes apply to 2.x.
msg77042 - (view) Author: Mark Dickinson (mark.dickinson) * (Python committer) Date: 2008-12-05 17:31
> r65789
That should be r67589.
History
Date User Action Args
2022-04-11 14:56:42adminsetgithub: 48747
2008-12-05 17:31:00mark.dickinsonsetmessages: + msg77042
2008-12-05 17:27:46mark.dickinsonsetstatus: open -> closed
resolution: fixed
messages: + msg77041
versions: - Python 2.6, Python 2.7
2008-12-03 23:02:07rhettingersetmessages: + msg76850
2008-12-03 21:58:06mark.dickinsonsetfiles: + issue4497.patch
keywords: + patch
messages: + msg76847
2008-12-03 09:48:11mark.dickinsonsetversions: + Python 2.6, Python 3.1, Python 2.7
2008-12-03 09:47:09mark.dickinsonsetmessages: + msg76818
2008-12-02 21:40:56rhettingercreate