Title: urllib.request.HTTPPasswordMgr.is_suburi does not care about order
Type: Stage:
Components: Library (Lib) Versions:
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: Fongeme, cheryl.sabella, gvanrossum
Priority: normal Keywords:

Created on 2021-01-09 21:23 by Fongeme, last changed 2021-01-11 00:28 by gvanrossum.

Pull Requests
URL Status Linked Edit
PR 24181 open Fongeme, 2021-01-09 21:23
Messages (2)
msg384741 - (view) Author: Yair Frid (Fongeme) * Date: 2021-01-09 21:23
In docs, it mentions that the function returns true if the base is a 'suburi' of test, but in reality, if is_suburi(base, test) then is_suburi(test, base) which is wrong in most cases (other than where base ~= test, meaning they are the same location)
I am unsure which versions of python are affected, but i suspect most of them (although we probably shouldn't backport this fix?)
msg384790 - (view) Author: Guido van Rossum (gvanrossum) * (Python committer) Date: 2021-01-11 00:28
Cheryl, do you have time to review this?
Date User Action Args
2021-01-11 00:28:44gvanrossumsetnosy: + gvanrossum, cheryl.sabella
messages: + msg384790
2021-01-09 21:23:37Fongemecreate