➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: imghdr.what is missing docstring, has a logic error, and is overly complex
Type: behavior Stage: resolved
Components: Library (Lib) Versions: Python 3.10
process
Status: closed Resolution: rejected
Dependencies: Superseder:
Assigned To: Nosy List: jph00
Priority: normal Keywords: patch

Created on 2020-11-01 04:31 by jph00, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 23069 closed jph00, 2020-11-01 04:34
Messages (1)
msg380114 - (view) Author: Jeremy Howard (jph00) * Date: 2020-11-01 04:31 
imghdr.what does not set f if h is passed, but still passed f to tests functions. None of the tests functions use it - they would not be able to anyway since it is not always set.

imghdr.what is missing a docstring.

imghdr.what has a complex highly nest structure with multiple return paths which makes the logic hard to follow.
History
Date User Action Args
2022-04-11 14:59:37adminsetgithub: 86392
2020-11-02 02:49:16jph00setstatus: open -> closed
resolution: rejected
stage: patch review -> resolved
2020-11-01 04:34:37jph00setkeywords: + patch
stage: patch review
pull_requests: + pull_request21988
2020-11-01 04:31:45jph00create