classification
Title: Reenable sendfile in shutil.copyfile() on Solaris
Type: performance Stage: patch review
Components: Library (Lib) Versions: Python 3.10, Python 3.9
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: giampaolo.rodola, jstasiak, kulikjak
Priority: normal Keywords: patch

Created on 2020-09-23 13:24 by kulikjak, last changed 2021-05-21 10:28 by kulikjak.

Pull Requests
URL Status Linked Edit
PR 23893 open kulikjak, 2020-12-22 17:19
Messages (2)
msg377383 - (view) Author: Jakub Kulik (kulikjak) * Date: 2020-09-23 13:24
The use of sendfile() in shutil.copyfile() on Solaris was previously disabled in #36610 due to slightly different behavior. This difference was recently accounted for in #41687, and I observed no other unexpected problems/differences with sendfile.

Can we get this reenabled? I can prepare PR, however, I am not sure whether #36610 should be reverted (hence enabling sendfile in copyfile on every system where it is available) or whether I should just add Solaris to _USE_CP_SENDFILE condition.
msg394102 - (view) Author: Jakub Kulik (kulikjak) * Date: 2021-05-21 10:28
Based on the comment https://bugs.python.org/issue43743#msg393429 I think my question is answered: #36610 should not be reverted. Attached PR (which merely adds Solaris to systems where _USE_CP_SENDFILE is True) should thus be the preferred way of reenabling this.
History
Date User Action Args
2021-05-21 10:28:24kulikjaksetmessages: + msg394102
2020-12-22 17:19:09kulikjaksetkeywords: + patch
stage: patch review
pull_requests: + pull_request22748
2020-11-05 17:01:59jstasiaksetnosy: + jstasiak
2020-09-23 13:24:12kulikjakcreate