➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: WinMain.c should use WIN32_LEAN_AND_MEAN
Type: Stage:
Components: Windows Versions:
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: mhammond Nosy List: krodgers, mhammond, tim.peters
Priority: normal Keywords:

Created on 2001-04-23 17:50 by krodgers, last changed 2022-04-10 16:04 by admin. This issue is now closed.

Messages (3)
msg4498 - (view) Author: Kevin Rodgers (krodgers) Date: 2001-04-23 17:50 
WinMain.c defines WINDOWS_LEAN_AND_MEAN prior to
including windows.h.  In VC++ 6.0, this is incorrect;
it should be WIN32_LEAN_AND_MEAN.  I don't have access
to VC++ 5.0, so I don't know if this is something that
changed between VC++ versions or not.
msg4499 - (view) Author: Tim Peters (tim.peters) * (Python committer) Date: 2001-04-24 05:19 
Logged In: YES 
user_id=31435

Wow!  I found no evidence that WINDOWS_LEAN_AND_MEAN has 
ever meant anything to MS, and gobs of evidence that it 
should have been WIN32_LEAN_AND_MEAN all along.  Thanks!

Checked in as

Misc/ACKS new revision: 1.96
PC/WinMain.c new revision: 1.7

Marked as Fixed but left Open, and assigned to MarkH in 
case we're both missing something subtle here:  Mark, if 
you agree with the change, just mark this Closed.  Else 
feel encouraged to scream at me.
msg4500 - (view) Author: Mark Hammond (mhammond) * (Python committer) Date: 2001-04-24 05:23 
Logged In: YES 
user_id=14198

yes, this is certainly correct!
History
Date User Action Args
2022-04-10 16:04:00adminsetgithub: 34401
2001-04-23 17:50:53krodgerscreate