This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Ignore error making grammar src if srcdir is readonly
Type: Stage:
Components: Build Versions:
process
Status: closed Resolution:
Dependencies: Superseder:
Assigned To: twouters Nosy List: nascheme, twouters
Priority: normal Keywords: patch

Created on 2001-02-21 13:38 by nascheme, last changed 2022-04-10 16:03 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
None nascheme, 2001-02-21 13:38 None
Messages (4)
msg35802 - (view) Author: Thomas Wouters (twouters) * (Python committer) Date: 2001-02-22 16:20
This doesn't look like it does what it is supposed to. At least, after applying the patch, Grammar doesn't get rebuilt at all, even when graminit.h is missing:

gcc -D_HAVE_BSDI -c -g -O2 -Wall -Wstrict-prototypes -I. -I../Include -DHAVE_CONFIG_H  -o Python/compile.o ../Python/compile.c
../Python/compile.c:17: graminit.h: No such file or directory

I can't seem to get it to make it, even though there is a $(GRAMINIT_H) dependancy. 'make Include/graminit.h' no longer works, and neither does anything else I can come up with.

But I'd like to note I'm still against rebuilding the Grammar automatically in releases :-) I'm not really sure if it's still worth rebuilding the Grammar each time, myself. It was when I did the original (horribly broken) patch, but that was in the heat of 2.0, with lots of Grammar-changing patch-proposals about.
msg35803 - (view) Author: Neil Schemenauer (nascheme) * (Python committer) Date: 2001-02-21 13:43
Does this make sense?  My last change making graminit.h
and graminit.c in the build directory was wrong.  The
compiler does not understand VPATH so the include
file could not be found.  The new idea is to continue the
build even if the grammar sources cannot be regenerated
(maybe the source directory is readonly).  I don't want
to remove the target completely since someone may change
the grammar and forget to generate the source.
msg35804 - (view) Author: Neil Schemenauer (nascheme) * (Python committer) Date: 2001-02-24 06:38
"If make doesn't do what you expect it to, it's a good
chance the makefile is wrong." -- BSD Make manual

Some dependances were missing.  Can you give the current
patch a whirl?  BTW, why to you think rebuilding the
grammar source is a bad idea?
msg35805 - (view) Author: Neil Schemenauer (nascheme) * (Python committer) Date: 2001-02-27 03:26
Logged In: YES 
user_id=35752

Applied.  The old behavor was much too broken to leave
for the beta.
History
Date User Action Args
2022-04-10 16:03:46adminsetgithub: 33984
2001-02-21 13:38:35naschemecreate