classification
Title: Test failures when CPython is built without docstrings
Type: behavior Stage: patch review
Components: Tests Versions: Python 3.9, Python 3.8, Python 3.7
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: ZackerySpytz, brett.cannon, eric.smith, terry.reedy
Priority: normal Keywords: patch

Created on 2019-07-05 03:30 by ZackerySpytz, last changed 2019-07-09 07:46 by terry.reedy.

Files
File name Uploaded Description Edit
test_failures_without_docstrings.txt ZackerySpytz, 2019-07-05 03:30
Pull Requests
URL Status Linked Edit
PR 14592 open ZackerySpytz, 2019-07-05 03:35
Messages (4)
msg347298 - (view) Author: Zackery Spytz (ZackerySpytz) * (Python triager) Date: 2019-07-05 03:30
test_coroutines, test_dataclasses, test_idle, test_importlib, test_module, and test_pydoc fail when CPython is built without docstrings. 

It seems that most of the failures occur simply because the test.support.requires_docstrings decorator is missing for some tests.

See also bpo-17041.
msg347361 - (view) Author: Brett Cannon (brett.cannon) * (Python committer) Date: 2019-07-05 17:24
Bit surprised by the test_importlib failure. What has crept into there that requires docstrings?
msg347363 - (view) Author: Eric V. Smith (eric.smith) * (Python committer) Date: 2019-07-05 17:39
Also surprised by the marked dataclasses tests. I don't see anything there that requires docstrings. See my review on the PR.
msg347527 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2019-07-09 07:46
Compiling without docstrings only affects compiled functions.  (Is this option unix only, for servers?)  This caused failures in 6 /test test functions.  Running with -00 only affects python functions.  It causes failure in 19 test function on Windows.  For IDLE, it causes many more failures than the configuration change. 

__doc__ == '' might have been less of a nuisance than == None, but too late to change that glocally now, although it can be a local solution.
History
Date User Action Args
2019-07-09 07:46:22terry.reedysetnosy: + terry.reedy
messages: + msg347527
2019-07-05 17:39:41eric.smithsetmessages: + msg347363
2019-07-05 17:24:09brett.cannonsetnosy: + brett.cannon
messages: + msg347361
2019-07-05 10:28:55eric.smithsetnosy: + eric.smith
2019-07-05 03:35:27ZackerySpytzsetkeywords: + patch
stage: patch review
pull_requests: + pull_request14408
2019-07-05 03:30:04ZackerySpytzcreate