classification
Title: Lib/cmd.py: Hide undocumented commands in help and completenames
Type: enhancement Stage: patch review
Components: Library (Lib) Versions: Python 3.8
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: aldwinaldwin, remi.lapeyre, xtreak
Priority: normal Keywords: patch

Created on 2019-05-24 07:25 by aldwinaldwin, last changed 2019-06-07 13:34 by aldwinaldwin.

Pull Requests
URL Status Linked Edit
PR 13536 open aldwinaldwin, 2019-05-24 07:35
Messages (6)
msg343346 - (view) Author: Aldwin Pollefeyt (aldwinaldwin) * Date: 2019-05-24 07:25
A flag, defaulting to false. If true, :meth:`do_help` and :meth:`completenames` won't include undocumented commands (that is, there are do_*() methods without corresponding help_*() methods).
msg343361 - (view) Author: Karthikeyan Singaravelan (xtreak) * (Python triager) Date: 2019-05-24 09:29
I believe this PR at least addresses the concern raised at [0] to provide a way where internal and undocumented commands can be hidden from the user.

[0] https://bugs.python.org/issue13214#msg309788
msg343873 - (view) Author: Aldwin Pollefeyt (aldwinaldwin) * Date: 2019-05-29 08:41
The EOF mentioned in [0] is indeed the same and was the first reason why I searched in the library code for a solution. Then saw it as an opportunity to create hidden functions in the shell.

[0] https://bugs.python.org/issue13214#msg309788
msg344346 - (view) Author: Aldwin Pollefeyt (aldwinaldwin) * Date: 2019-06-03 00:33
How to add a label 'awaiting core review' to pull request?

tirkarthi: "Left comment for doc and test. But in general would like to hear from a core dev on this."
msg344422 - (view) Author: Rémi Lapeyre (remi.lapeyre) * Date: 2019-06-03 14:25
It will be done automatically after someone validated the PR.
msg344935 - (view) Author: Aldwin Pollefeyt (aldwinaldwin) * Date: 2019-06-07 13:34
Can there be a review of the PR to let me know if all changes are correct?
History
Date User Action Args
2019-06-07 13:34:33aldwinaldwinsetmessages: + msg344935
2019-06-03 14:25:40remi.lapeyresetnosy: + remi.lapeyre
messages: + msg344422
2019-06-03 00:33:29aldwinaldwinsetmessages: + msg344346
2019-05-29 08:41:27aldwinaldwinsetmessages: + msg343873
2019-05-24 09:29:53xtreaksetnosy: + xtreak
messages: + msg343361
2019-05-24 07:35:53aldwinaldwinsetkeywords: + patch
stage: patch review
pull_requests: + pull_request13450
2019-05-24 07:25:53aldwinaldwincreate