This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: _thread.interrupt_main() no longer interrupts Lock.wait
Type: behavior Stage: needs patch
Components: Documentation, Extension Modules, Library (Lib) Versions: Python 3.8
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: docs@python Nosy List: docs@python, eryksun, gregory.p.smith
Priority: normal Keywords:

Created on 2019-04-05 20:07 by gregory.p.smith, last changed 2022-04-11 14:59 by admin.

Messages (2)
msg339518 - (view) Author: Gregory P. Smith (gregory.p.smith) * (Python committer) Date: 2019-04-05 20:07
In Python 2.7 our threading implementation was so poor that a thread join ultimately called our lock wait implementation that busy looped polling and sleeping to check for a lock acquisition success.  calling thread.interrupt_main() which is just PyErr_SetInterrupt() C API in disguise successfully broke out of that lock wait loop.

In Python 3 with our drastically improved threading implementation, a lock wait is a pthreads sem_timedwait() or sem_trywait() API call, blocking within the pthreads library or OS kernel.  PyErr_SetInterrupt() obviously has no effect on that.  Only an actual signal arriving can interrupt that.

Thus instead of code using _thread.interrupt_main() - in 2and3 compatible applications, six.moves._thread.interrupt_main() - they should instead write:

 os.kill(os.getpid(), signal.SIGINT)

Given that _thread is a private module making _thread.interrupt_main() a private API, do we need to keep it?  If we do, we should at least document this behavior and recommend actually sending the signal.  It is less capable of actually interrupting the main thread from some common blocking operations today.  Sending the signal seems like it would always be better.
msg339528 - (view) Author: Eryk Sun (eryksun) * (Python triager) Date: 2019-04-06 07:28
Windows doesn't implement POSIX signals in the kernel, so _thread.interrupt_main (i.e. PyErr_SetInterrupt) can be useful as an abstraction. 

Currently PyErr_SetInterrupt (Modules/signalmodule.c) doesn't set our SIGINT event in Windows. It was suggested in issue 29926 to replace the trip_signal call with raise(SIGINT). That works for Windows -- as long as we're not concerned about emulating Ctrl+C exactly as if the user typed it in the console (if we're attached to a console). In POSIX, raise(SIGINT) won't interrupt the main thread if it's in a blocking system call, since it targets pthread_self(), so PyErr_SetInterrupt can instead call kill(getpid(), SIGINT), as you suggest, or pthread_kill(main_thread, SIGINT). 

3.8 adds signal.raise_signal (see issue 35568), so it's possible to implement this in pure Python. Either way, it would be nice to keep it as a cross-platform function, and hopefully make it public and documented.

Another option would be to enhance our Windows implementation of os.kill to more closely match POSIX kill(), such that os.kill(os.getpid(), signal.SIGINT) is implemented as raise(SIGINT). That would be a breaking change since currently it calls TerminateProcess (an abrupt termination like POSIX SIGKILL).
History
Date User Action Args
2022-04-11 14:59:13adminsetgithub: 80719
2019-04-06 07:28:06eryksunsetnosy: + eryksun
messages: + msg339528
2019-04-05 20:07:07gregory.p.smithcreate