This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: logging.makeLogRecord should update "rv" using a dict defined with bytes instead of strings
Type: enhancement Stage: resolved
Components: Library (Lib) Versions: Python 3.5
process
Status: closed Resolution: not a bug
Dependencies: Superseder:
Assigned To: Nosy List: ralonsoh, vinay.sajip, xtreak
Priority: normal Keywords:

Created on 2019-02-19 10:46 by ralonsoh, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Messages (4)
msg335925 - (view) Author: Rodolfo Alonso (ralonsoh) Date: 2019-02-19 10:46
When using Pycharm to execute unit/functional tests (OpenStack development), oslo_privsep.daemon._ClientChannel.out_of_band retrieves the record from the input arguments. Pycharm arguments are stored in a dictionary using bytes instead of strings.

When logging.makeLogRecord tries to update "rv", the value in "dict" parameter (using bytes) doesn't update "rv" values.
msg335989 - (view) Author: Karthikeyan Singaravelan (xtreak) * (Python committer) Date: 2019-02-19 17:41
Sorry, I don't get the report. Can you please add a short reproducer script with a description of the current behavior and the expected behavior?
msg335999 - (view) Author: Vinay Sajip (vinay.sajip) * (Python committer) Date: 2019-02-19 19:04
If the arguments are retrieved from a byte source, why can't they be converted to strings before passing to logging? This may be an issue for OpenStack. It's not logging's job to convert bytes passed to APIs that expect strings.
msg346055 - (view) Author: Vinay Sajip (vinay.sajip) * (Python committer) Date: 2019-06-19 14:53
Closing, as no further feedback from issue reporter. Feel free to reopen if you have a good response to my last comment.
History
Date User Action Args
2022-04-11 14:59:11adminsetgithub: 80214
2019-06-19 14:53:30vinay.sajipsetstatus: open -> closed
resolution: not a bug
messages: + msg346055

stage: resolved
2019-02-19 19:04:09vinay.sajipsetmessages: + msg335999
2019-02-19 17:41:38xtreaksetnosy: + xtreak
messages: + msg335989
2019-02-19 16:01:29SilentGhostsetnosy: + vinay.sajip
components: + Library (Lib)
2019-02-19 10:46:00ralonsohcreate