classification
Title: Logging module cleanup
Type: enhancement Stage: resolved
Components: Extension Modules Versions: Python 3.8
process
Status: closed Resolution: wont fix
Dependencies: Superseder:
Assigned To: Nosy List: Solomon Ucko, vinay.sajip
Priority: normal Keywords:

Created on 2018-12-24 03:05 by Solomon Ucko, last changed 2018-12-24 16:11 by vinay.sajip. This issue is now closed.

Messages (2)
msg332401 - (view) Author: Solomon Ucko (Solomon Ucko) Date: 2018-12-24 03:05
The logging module should be changed to use snake_case (as opposed to camelCase). Also, logger.basicConfig should list keyword arguments and defaults in the argument list, as opposed to using `**kwargs` and `dict.pop` (for readability and improved inspection capabilities). These should both be relatively easy changes to make. The case conversion should leave the camelCase versions as deprecated but left for backwards compatibility (as in the operator module).
msg332478 - (view) Author: Vinay Sajip (vinay.sajip) * (Python committer) Date: 2018-12-24 16:11
I don't believe there is enough value in this to do it. From PEP 8:

"Some other good reasons to ignore a particular guideline:

...
Because the code in question predates the introduction of the guideline and there is no other reason to be modifying that code.
...
"

That applies to both snake_casing (no functional improvement) and the basicConfig change (no worthwhile functional improvement; documentation covers, or should cover, the actual keyword arguments; it's not clear in what context improved inspection capabilities would be particularly helpful for basicConfig. It's not as if this is the only usage of **kwargs in the stdlib).

The energy that would be spent on doing this would be better spent on other things, IMO.
History
Date User Action Args
2018-12-24 16:11:47vinay.sajipsetstatus: open -> closed
resolution: wont fix
messages: + msg332478

stage: resolved
2018-12-24 03:37:48ned.deilysetnosy: + vinay.sajip

versions: - Python 2.7, Python 3.4, Python 3.5, Python 3.6, Python 3.7
2018-12-24 03:05:29Solomon Uckocreate