classification
Title: Incorrect use of raise NotImplemented
Type: Stage: resolved
Components: Library (Lib) Versions: Python 3.8
process
Status: closed Resolution: duplicate
Dependencies: Superseder:
Assigned To: Nosy List: brett.cannon, rth
Priority: normal Keywords: patch

Created on 2018-12-06 20:01 by rth, last changed 2018-12-07 23:41 by brett.cannon. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 10999 closed rth, 2018-12-06 20:08
Messages (3)
msg331244 - (view) Author: Roman Yurchak (rth) * Date: 2018-12-06 20:01
In two places in stdlib, `raise NotImplemented` is used instead of `raise NotImplementedError`. The former is not valid and produces,

```
>>> raise NotImplemented('message')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: 'NotImplementedType' object is not callable
```
msg331278 - (view) Author: Roman Yurchak (rth) * Date: 2018-12-07 07:08
Resolved in https://bugs.python.org/issue33023
msg331367 - (view) Author: Brett Cannon (brett.cannon) * (Python committer) Date: 2018-12-07 23:41
This was fixed by https://github.com/python/cpython/pull/10934
History
Date User Action Args
2018-12-07 23:41:45brett.cannonsetstatus: open -> closed

nosy: + brett.cannon
messages: + msg331367

stage: patch review -> resolved
2018-12-07 07:08:27rthsetresolution: duplicate
messages: + msg331278
2018-12-06 20:08:48rthsetkeywords: + patch
stage: patch review
pull_requests: + pull_request10237
2018-12-06 20:01:58rthcreate