➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2018-11-13 14:30 by Antony.Lee, last changed 2022-04-11 14:59 by admin.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 11371 | open | remi.lapeyre, 2018-12-30 20:06 | |
| PR 11371 | open | remi.lapeyre, 2018-12-30 20:06 | |
| Messages (3) | |||
|---|---|---|---|
| msg329847 - (view) | Author: Antony Lee (Antony.Lee) * | Date: 2018-11-13 14:30 | |
Currently, dataclasses created by make_dataclass are not picklable, because their __module__ is set to "types". It seems that this would be easily fixed by letting make_dataclass gain a `module` and a `qualname` kwarg, similarly to the Enum functional form (https://docs.python.org/3/library/enum.html#functional-api). |
|||
| msg332761 - (view) | Author: Rémi Lapeyre (remi.lapeyre) * | Date: 2018-12-30 20:36 | |
Hi @Anthony.Lee, the __module__ is wrong indeed. The new changeset in https://github.com/python/cpython/pull/11371 should implement what you need. If you don't specify the new `module` and `qualname` parameters, make_dataclass() will try to determine the correct `module` so you should not need to change your code. |
|||
| msg342283 - (view) | Author: Cheryl Sabella (cheryl.sabella) *  |
Date: 2019-05-13 03:47 | |
@eric.smith Can you take a look at this when you get a chance? Thanks! |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:08 | admin | set | github: 79413 |
| 2020-06-21 00:43:53 | remi.lapeyre | set | versions: + Python 3.7, Python 3.8, Python 3.9 |
| 2020-06-21 00:43:19 | remi.lapeyre | set | versions: + Python 3.10, - Python 3.8 |
| 2019-05-13 03:47:38 | cheryl.sabella | set | keywords:
patch, patch nosy: + cheryl.sabella messages: + msg342283 |
| 2019-04-11 13:03:31 | Antony.Lee | set | nosy:
- Antony.Lee |
| 2019-04-11 12:46:46 | cheryl.sabella | set | keywords:
patch, patch type: enhancement versions: + Python 3.8, - Python 3.7 |
| 2018-12-30 20:36:24 | remi.lapeyre | set | nosy:
+ remi.lapeyre messages: + msg332761 |
| 2018-12-30 20:06:58 | remi.lapeyre | set | keywords:
+ patch stage: patch review pull_requests: + pull_request10711 |
| 2018-12-30 20:06:51 | remi.lapeyre | set | keywords:
+ patch stage: (no value) pull_requests: + pull_request10710 |
| 2018-11-16 21:38:56 | levkivskyi | set | nosy:
+ levkivskyi |
| 2018-11-13 18:35:28 | xtreak | set | nosy:
+ eric.smith |
| 2018-11-13 14:30:46 | Antony.Lee | create | |