This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Typo in hamt.c comments
Type: enhancement Stage: resolved
Components: Documentation Versions: Python 3.8, Python 3.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: docs@python Nosy List: delimitry, docs@python, yselivanov
Priority: normal Keywords: patch

Created on 2018-02-01 17:16 by delimitry, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 5478 merged delimitry, 2018-02-01 17:18
Messages (3)
msg311452 - (view) Author: Dmitry Alimov (delimitry) * Date: 2018-02-01 17:16
In the comments to `hamt_node_collision_without` function in hamt.c module, I think should be `so convert` instead of `co convert`:

```
             if (new_count == 1) {
                 /* The node has two keys, and after deletion the
                    new Collision node would have one.  Collision nodes
-                   with one key shouldn't exist, co convert it to a
+                   with one key shouldn't exist, so convert it to a
                    Bitmap node.
                 */
```
msg311453 - (view) Author: Yury Selivanov (yselivanov) * (Python committer) Date: 2018-02-01 17:17
Yeah, please submit a PR
msg311510 - (view) Author: Dmitry Alimov (delimitry) * Date: 2018-02-02 20:04
Fixed
History
Date User Action Args
2022-04-11 14:58:57adminsetgithub: 76924
2018-02-02 20:04:57delimitrysetstatus: open -> closed
resolution: fixed
messages: + msg311510

stage: patch review -> resolved
2018-02-01 17:18:43delimitrysetkeywords: + patch
stage: patch review
pull_requests: + pull_request5307
2018-02-01 17:17:22yselivanovsetmessages: + msg311453
2018-02-01 17:16:51delimitrycreate