classification
Title: [urllib] proxy_bypass_registry - extra error handling required for ProxyOverride, Windows under proxy environment
Type: behavior Stage:
Components: Library (Lib) Versions: Python 3.11
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: chansol kim, iritkatriel
Priority: normal Keywords: easy

Created on 2017-12-31 14:01 by chansol kim, last changed 2021-06-18 09:32 by iritkatriel.

Messages (2)
msg309284 - (view) Author: chansol kim (chansol kim) Date: 2017-12-31 14:01
[Problem]
- String value from registry Proxy override is read and incorrectly decides the current connection requires not to use proxy.

[Setup]
- Using urllib under proxy environment.
- Proxy bypass settings are in place. ProxyOverride string value in registry ends with ;

[Detail]
https://github.com/python/cpython/blob/2.7/Lib/urllib.py
proxy_bypass_registry has an issue
1. It gets registry value from HKCU\Software\Microsoft\Windows\CurrentVersion\Internet Settings ProxyEnable string value.
2. Splits the string with ;. And as the registry value ends with ; the split list contains a zero length string at the end.
3. Use the split string to re.match. And as there is zero length string at the end it, and the result of re.match('', 'anystring', re.I) is always not None.
4. Afterwards connection is attempted without using the proxy, hence connection cannot be made

From line 1617

        proxyOverride = proxyOverride.split(';')
        # now check if we match one of the registry values.
        for test in proxyOverride:
            if test == '<local>':
                if '.' not in rawHost:
                    return 1
            test = test.replace(".", r"\.")     # mask dots
            test = test.replace("*", r".*")     # change glob sequence
            test = test.replace("?", r".")      # change glob char
            for val in host:
                # print "%s <--> %s" %( test, val )
                if re.match(test, val, re.I):
                    return 1
msg396036 - (view) Author: Irit Katriel (iritkatriel) * (Python committer) Date: 2021-06-18 09:32
There are currently no unit tests for proxy_bypass_registry, proxy_bypass, and nothing much for proxy_open. Those should be added as part of this work.
History
Date User Action Args
2021-06-18 09:32:03iritkatrielsetversions: + Python 3.11, - Python 2.7
nosy: + iritkatriel

messages: + msg396036

keywords: + easy
2017-12-31 14:01:24chansol kimcreate